Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 2593783002: Report FoundUwSReadError only once per Software Reporter run. (Closed)

Created:
4 years ago by ftirelo
Modified:
4 years ago
Reviewers:
Jialiu Lin, alito
CC:
chromium-reviews, grt+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Report FoundUwSReadError only once per Software Reporter run. This was introduced by https://codereview.chromium.org/2347753002, during a code refactoring. The bug is not critical, since we don't look at this data with much frequency, but we should revert it to the intended behavior. BUG=676031 Committed: https://crrev.com/3e4d1fa0962b07d2b09cdd999fd9e90a7e71f926 Cr-Commit-Position: refs/heads/master@{#439889}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M chrome/browser/safe_browsing/srt_fetcher_win.cc View 1 chunk +4 lines, -5 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
ftirelo
4 years ago (2016-12-20 19:29:10 UTC) #2
alito
lgtm
4 years ago (2016-12-20 19:32:27 UTC) #3
ftirelo
Adding jialiul@ for owners approval.
4 years ago (2016-12-20 19:35:05 UTC) #5
ftirelo
4 years ago (2016-12-20 20:35:11 UTC) #7
Jialiu Lin
lgtm
4 years ago (2016-12-20 21:16:07 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2593783002/1
4 years ago (2016-12-20 21:19:09 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-20 22:08:38 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-20 22:11:19 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3e4d1fa0962b07d2b09cdd999fd9e90a7e71f926
Cr-Commit-Position: refs/heads/master@{#439889}

Powered by Google App Engine
This is Rietveld 408576698