scripts/slave/recipe_modules/chromium_android/chromium_config.py - Issue 2593683002: [Cronet] set use_partition_alloc to false in Cronet recipes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipe_modules/chromium_android/chromium_config.py

Issue 2593683002: [Cronet] set use_partition_alloc to false in Cronet recipes (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: scripts/slave/recipe_modules/chromium_android/chromium_config.py

diff --git a/scripts/slave/recipe_modules/chromium_android/chromium_config.py b/scripts/slave/recipe_modules/chromium_android/chromium_config.py

index 4ea41fe546603067633856653170290cecb007cf..772d3958b54af00d3a9167fee64581389e65ddd9 100644

--- a/scripts/slave/recipe_modules/chromium_android/chromium_config.py

+++ b/scripts/slave/recipe_modules/chromium_android/chromium_config.py

@@ -78,11 +78,13 @@ def cronet_builder(c):

c.gyp_env.GYP_DEFINES['disable_ftp_support'] = 1

c.gyp_env.GYP_DEFINES['enable_websockets'] = 0

c.gyp_env.GYP_DEFINES['use_platform_icu_alternatives'] = 1

+ c.gyp_env.GYP_DEFINES['use_partition_alloc'] = 0

jbudorick 2016/12/20 16:51:56 I think we can get rid of the GYP_DEFINES now, but

xunjieli 2016/12/20 17:29:07 Done.

c.gn_args.append('disable_brotli_filter=true')

c.gn_args.append('disable_file_support=true')

c.gn_args.append('disable_ftp_support=true')

c.gn_args.append('enable_websockets=false')

c.gn_args.append('use_platform_icu_alternatives=true')

+ c.gn_args.append('use_partition_alloc=false')

# TODO(jbudorick): Remove {cronet,net}_unittests_apk targets after

# gn switch is finished.

c.compile_py.default_targets=['cronet_package',

« no previous file with comments | « no previous file | scripts/slave/recipe_modules/cronet/example.expected/gn_test.json » ('j') | no next file with comments »