Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 2593673003: Support 420mpeg2 Y4M input in FileVideoCaptureDevice (Closed)

Created:
4 years ago by emircan
Modified:
4 years ago
Reviewers:
mcasas
CC:
chromium-reviews, posciak+watch_chromium.org, feature-media-reviews_chromium.org, xjz+watch_chromium.org, mcasas+watch+vc_chromium.org, miu+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Support 420mpeg2 Y4M input in FileVideoCaptureDevice BUG=676061 TEST=Tested an AppRTC loopback with a 420mpeg2 Y4M file input Committed: https://crrev.com/90feaad3be7d5411f4570b327e641599fe183dee Cr-Commit-Position: refs/heads/master@{#439898}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M media/capture/video/file_video_capture_device.cc View 1 chunk +2 lines, -1 line 1 comment Download

Messages

Total messages: 15 (10 generated)
emircan
PTAL.
4 years ago (2016-12-20 19:44:23 UTC) #5
mcasas
lgtm https://codereview.chromium.org/2593673003/diff/1/media/capture/video/file_video_capture_device.cc File media/capture/video/file_video_capture_device.cc (right): https://codereview.chromium.org/2593673003/diff/1/media/capture/video/file_video_capture_device.cc#newcode95 media/capture/video/file_video_capture_device.cc:95: token == "420paldv") Funny formatting, but if git ...
4 years ago (2016-12-20 19:57:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2593673003/1
4 years ago (2016-12-20 20:55:18 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-20 22:50:37 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-20 22:52:57 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/90feaad3be7d5411f4570b327e641599fe183dee
Cr-Commit-Position: refs/heads/master@{#439898}

Powered by Google App Engine
This is Rietveld 408576698