Fix use-after-free in WidgetCaptureTest.SetCaptureToNonToplevel.

Fix use-after-free in WidgetCaptureTest.SetCaptureToNonToplevel.

This test case calls AddObserver with a pointer to a local variable.
The observer is then called during the test instance destruction,
when the local variable is already out of scope.

The fix is to call RemoveObserver while the observer variable is
still alive.

The bug was found by AddressSanitizer with use-after-scope check enabled.

BUG=649897
Committed: https://crrev.com/f51080b57ed7b3570a7a890b6ad5ef4ddf49747e
Cr-Commit-Position: refs/heads/master@{#440001}

[krasin1, 2016-12-20 23:15:49]

krasin@chromium.org changed reviewers:
+ sadrul@chromium.org

[krasin1, 2016-12-20 23:15:55]

The CQ bit was checked by krasin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-20 23:16:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-21 00:12:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-21 00:12:07]

Dry run: This issue passed the CQ dry run.

[sadrul, 2016-12-21 02:06:38]

lgtm Thanks!

[krasin1, 2016-12-21 03:38:56]

The CQ bit was checked by krasin@chromium.org

[commit-bot: I haz the power, 2016-12-21 03:39:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-21 03:43:42]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1482291536604180, "parent_rev":
"f7c590c2738cc6cdae8aaf1b928a4becea288d8e", "commit_rev":
"80f19a88d95192cfe59a8cfc1bf6c873d870e939"}

[commit-bot: I haz the power, 2016-12-21 03:44:15]

Description was changed from

==========
Fix use-after-free in WidgetCaptureTest.SetCaptureToNonToplevel.

This test case calls AddObserver with a pointer to a local variable.
The observer is then called during the test instance destruction,
when the local variable is already out of scope.

The fix is to call RemoveObserver while the observer variable is
still alive.

The bug was found by AddressSanitizer with use-after-scope check enabled.

BUG=649897
==========

to

==========
Fix use-after-free in WidgetCaptureTest.SetCaptureToNonToplevel.

This test case calls AddObserver with a pointer to a local variable.
The observer is then called during the test instance destruction,
when the local variable is already out of scope.

The fix is to call RemoveObserver while the observer variable is
still alive.

The bug was found by AddressSanitizer with use-after-scope check enabled.

BUG=649897

Review-Url: https://codereview.chromium.org/2593613003
==========

[commit-bot: I haz the power, 2016-12-21 03:44:15]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-21 03:48:09]

Description was changed from

==========
Fix use-after-free in WidgetCaptureTest.SetCaptureToNonToplevel.

This test case calls AddObserver with a pointer to a local variable.
The observer is then called during the test instance destruction,
when the local variable is already out of scope.

The fix is to call RemoveObserver while the observer variable is
still alive.

The bug was found by AddressSanitizer with use-after-scope check enabled.

BUG=649897

Review-Url: https://codereview.chromium.org/2593613003
==========

to

==========
Fix use-after-free in WidgetCaptureTest.SetCaptureToNonToplevel.

This test case calls AddObserver with a pointer to a local variable.
The observer is then called during the test instance destruction,
when the local variable is already out of scope.

The fix is to call RemoveObserver while the observer variable is
still alive.

The bug was found by AddressSanitizer with use-after-scope check enabled.

BUG=649897

Committed: https://crrev.com/f51080b57ed7b3570a7a890b6ad5ef4ddf49747e
Cr-Commit-Position: refs/heads/master@{#440001}
==========

[commit-bot: I haz the power, 2016-12-21 03:48:10]

Patchset 1 (id:??) landed as
https://crrev.com/f51080b57ed7b3570a7a890b6ad5ef4ddf49747e
Cr-Commit-Position: refs/heads/master@{#440001}