Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 2593593002: [builtins] Fix String.prototype.indexOf with negative positions (Closed)

Created:
4 years ago by Camillo Bruni
Modified:
4 years ago
Reviewers:
petermarshall
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[builtins] Fix String.prototype.indexOf with negative positions BUG=chromium:674889 Review-Url: https://codereview.chromium.org/2593593002 Cr-Commit-Position: refs/heads/master@{#41858} Committed: https://chromium.googlesource.com/v8/v8/+/c1402cbde3a08f6d165a301c6f5596ca895ee0e7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M src/builtins/builtins-string.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/mjsunit/string-indexof-1.js View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Camillo Bruni
PTAL
4 years ago (2016-12-20 11:46:41 UTC) #4
petermarshall
lgtm
4 years ago (2016-12-20 12:28:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2593593002/1
4 years ago (2016-12-20 12:39:21 UTC) #9
commit-bot: I haz the power
4 years ago (2016-12-20 12:41:02 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/c1402cbde3a08f6d165a301c6f5596ca895...

Powered by Google App Engine
This is Rietveld 408576698