cc: Prevent float-cast-overflow in MapRectInternal.

cc: Prevent float-cast-overflow in MapRectInternal.

This changes from using ints to express the blur spread, to keeping the
arithmetic as floats until producing the result, using ToEnclosingRect
(which uses saturated_cast to convert). This is similar to how the drop
shadow code works.

The CL that enabled -fsanitize=float-cast-overflow has since been reverted:
  https://codereview.chromium.org/2598813002/

But I'd already written this before I realized that.

BUG=675177
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Committed: https://crrev.com/d52ae8cb7575fab9f7904475299e872e6c013570
Cr-Commit-Position: refs/heads/master@{#440530}

[jbroman, 2016-12-21 18:38:00]

Description was changed from

==========
cc: Prevent float-cast-overflow in MapRectInternal.

TODO(jbroman): Explain in detail what this does.

BUG=675177
==========

to

==========
cc: Prevent float-cast-overflow in MapRectInternal.

TODO(jbroman): Explain in detail what this does.

BUG=675177
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[jbroman, 2016-12-21 18:38:02]

The CQ bit was checked by jbroman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-21 18:38:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-21 20:16:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-21 20:16:12]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[jbroman, 2016-12-22 20:38:38]

Description was changed from

==========
cc: Prevent float-cast-overflow in MapRectInternal.

TODO(jbroman): Explain in detail what this does.

BUG=675177
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
cc: Prevent float-cast-overflow in MapRectInternal.

TODO(jbroman): Explain in detail what this does. Also it's wrong.

BUG=675177
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[jbroman, 2016-12-22 21:07:17]

The CQ bit was checked by jbroman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-22 21:07:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jbroman, 2016-12-22 21:08:40]

Description was changed from

==========
cc: Prevent float-cast-overflow in MapRectInternal.

TODO(jbroman): Explain in detail what this does. Also it's wrong.

BUG=675177
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
cc: Prevent float-cast-overflow in MapRectInternal.

This changes from using ints to express the blur spread, to keeping the
arithmetic as floats until producing the result, using ToEnclosingRect
(which uses saturated_cast to convert). This is similar to how the drop
shadow code works.

The CL that enabled -fsanitize=float-cast-overflow has since been reverted:
  https://codereview.chromium.org/2598813002/

But I'd already written this before I realized that.

BUG=675177
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[jbroman, 2016-12-22 21:09:00]

jbroman@chromium.org changed reviewers:
+ danakj@chromium.org

[danakj, 2016-12-22 21:11:29]

LGTM

[jbroman, 2016-12-22 21:13:40]

The CQ bit was unchecked by jbroman@chromium.org

[jbroman, 2016-12-22 21:13:41]

The CQ bit was checked by jbroman@chromium.org

[commit-bot: I haz the power, 2016-12-22 21:13:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-22 22:44:30]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1482441221751690,
"parent_rev": "5b9df4130ac36afc1356c4ce8db430d53dc903e1", "commit_rev":
"f8fb75c86a896f6826d353ef7f38cfc495ba0463"}

[commit-bot: I haz the power, 2016-12-22 22:45:02]

Description was changed from

==========
cc: Prevent float-cast-overflow in MapRectInternal.

This changes from using ints to express the blur spread, to keeping the
arithmetic as floats until producing the result, using ToEnclosingRect
(which uses saturated_cast to convert). This is similar to how the drop
shadow code works.

The CL that enabled -fsanitize=float-cast-overflow has since been reverted:
  https://codereview.chromium.org/2598813002/

But I'd already written this before I realized that.

BUG=675177
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
cc: Prevent float-cast-overflow in MapRectInternal.

This changes from using ints to express the blur spread, to keeping the
arithmetic as floats until producing the result, using ToEnclosingRect
(which uses saturated_cast to convert). This is similar to how the drop
shadow code works.

The CL that enabled -fsanitize=float-cast-overflow has since been reverted:
  https://codereview.chromium.org/2598813002/

But I'd already written this before I realized that.

BUG=675177
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2593583005
==========

[commit-bot: I haz the power, 2016-12-22 22:45:03]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-22 22:47:22]

Description was changed from

==========
cc: Prevent float-cast-overflow in MapRectInternal.

This changes from using ints to express the blur spread, to keeping the
arithmetic as floats until producing the result, using ToEnclosingRect
(which uses saturated_cast to convert). This is similar to how the drop
shadow code works.

The CL that enabled -fsanitize=float-cast-overflow has since been reverted:
  https://codereview.chromium.org/2598813002/

But I'd already written this before I realized that.

BUG=675177
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2593583005
==========

to

==========
cc: Prevent float-cast-overflow in MapRectInternal.

This changes from using ints to express the blur spread, to keeping the
arithmetic as floats until producing the result, using ToEnclosingRect
(which uses saturated_cast to convert). This is similar to how the drop
shadow code works.

The CL that enabled -fsanitize=float-cast-overflow has since been reverted:
  https://codereview.chromium.org/2598813002/

But I'd already written this before I realized that.

BUG=675177
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Committed: https://crrev.com/d52ae8cb7575fab9f7904475299e872e6c013570
Cr-Commit-Position: refs/heads/master@{#440530}
==========

[commit-bot: I haz the power, 2016-12-22 22:47:23]

Patchset 2 (id:??) landed as
https://crrev.com/d52ae8cb7575fab9f7904475299e872e6c013570
Cr-Commit-Position: refs/heads/master@{#440530}