chrome/android/javatests/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerViewTest.java - Issue 2593573003: Ntp: use AMP urls for content suggestions when available.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerViewTest.java

Issue 2593573003: Ntp: use AMP urls for content suggestions when available. (Closed)

Patch Set: Address review comments by vitalii. Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java ('k') | chrome/android/javatests/src/org/chromium/chrome/browser/ntp/snippets/ArticleSnippetsTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerViewTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerViewTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerViewTest.java

index aa2aece77358681eb8bb0426a4cd0bdb699ab733..7dac055eef67ac12990ad9a7093ec742a0fca254 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerViewTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerViewTest.java

@@ -110,7 +110,7 @@ public class NewTabPageRecyclerViewTest extends ChromeTabbedActivityTestBase {

@MediumTest

@Feature({"NewTabPage"})

@CommandLineFlags.Add("enable-features=NTPSnippets")

- public void testClickSuggestion() throws InterruptedException, TimeoutException {

+ public void testClickSuggestion() throws InterruptedException {

setSuggestionsAndWaitForUpdate(10);

List<SnippetArticle> suggestions =

mSource.getSuggestionsForCategory(KnownCategories.ARTICLES);

@@ -268,8 +268,7 @@ public class NewTabPageRecyclerViewTest extends ChromeTabbedActivityTestBase {

});

}

- private void setSuggestionsAndWaitForUpdate(final int suggestionsCount)

- throws InterruptedException, TimeoutException {

+ private void setSuggestionsAndWaitForUpdate(final int suggestionsCount) {

final FakeSuggestionsSource source = mSource;

ThreadUtils.runOnUiThreadBlocking(new Runnable() {

@@ -288,7 +287,7 @@ public class NewTabPageRecyclerViewTest extends ChromeTabbedActivityTestBase {

for (int i = 0; i < suggestionsCount; i++) {

String url = mTestServer.getURL(TEST_PAGE) + "#" + i;

suggestions.add(new SnippetArticle(KnownCategories.ARTICLES, "id" + i, "title" + i,

- "publisher" + i, "previewText" + i, url, url, 1466614774 + i, 10f, 0));

+ "publisher" + i, "previewText" + i, url, 1466614774 + i, 10f, 0));

}

return suggestions;

}