chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java - Issue 2593573003: Ntp: use AMP urls for content suggestions when available.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java

Issue 2593573003: Ntp: use AMP urls for content suggestions when available. (Closed)

Patch Set: Address review comments by vitalii. Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticle.java ('k') | chrome/android/javatests/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerViewTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java

index 5b84e67138aa47869565ef4b579ac40622e3cb09..a3cbb6d98b4508004673a4fd8c2241afae37e8a3 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java

@@ -206,10 +206,10 @@ public class SnippetsBridge implements SuggestionsSource {

@CalledByNative

private static SnippetArticle addSuggestion(List<SnippetArticle> suggestions, int category,

String id, String title, String publisher, String previewText, String url,

- String ampUrl, long timestamp, float score) {

+ long timestamp, float score) {

int position = suggestions.size();

- suggestions.add(new SnippetArticle(category, id, title, publisher, previewText, url, ampUrl,

- timestamp, score, position));

+ suggestions.add(new SnippetArticle(

+ category, id, title, publisher, previewText, url, timestamp, score, position));

return suggestions.get(position);

}