Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2593563002:
Tweak the share screen animation (Closed)
DescriptionTweak the share screen animation
Change the share view animation from fade in/slide up to slide up/slide down.
BUG=672773
Committed: https://crrev.com/b1309cfb4d2c0d22a5caeef6cd8883dd801250fb
Cr-Commit-Position: refs/heads/master@{#439826}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Fix direction #
Total comments: 2
Messages
Total messages: 15 (6 generated)
gambard@chromium.org changed reviewers: + olivierrobin@google.com
PTAL.
olivierrobin@chromium.org changed reviewers: + olivierrobin@chromium.org
https://codereview.chromium.org/2593563002/diff/1/ios/chrome/share_extension/... File ios/chrome/share_extension/share_view_controller.mm (right): https://codereview.chromium.org/2593563002/diff/1/ios/chrome/share_extension/... ios/chrome/share_extension/share_view_controller.mm:203: - (void)dismissAndReturnItem:(NSExtensionItem*)item { Animation should still slide up if you select an option (and not cancel).
Thanks, PTAL. https://codereview.chromium.org/2593563002/diff/1/ios/chrome/share_extension/... File ios/chrome/share_extension/share_view_controller.mm (right): https://codereview.chromium.org/2593563002/diff/1/ios/chrome/share_extension/... ios/chrome/share_extension/share_view_controller.mm:203: - (void)dismissAndReturnItem:(NSExtensionItem*)item { On 2016/12/20 10:04:16, Olivier Robin wrote: > Animation should still slide up if you select an option (and not cancel). Done.
https://codereview.chromium.org/2593563002/diff/20001/ios/chrome/share_extens... File ios/chrome/share_extension/share_view_controller.mm (right): https://codereview.chromium.org/2593563002/diff/20001/ios/chrome/share_extens... ios/chrome/share_extension/share_view_controller.mm:121: [self.maskView setAlpha:1]; Is this needed? Will this not also fade in ?
https://codereview.chromium.org/2593563002/diff/20001/ios/chrome/share_extens... File ios/chrome/share_extension/share_view_controller.mm (right): https://codereview.chromium.org/2593563002/diff/20001/ios/chrome/share_extens... ios/chrome/share_extension/share_view_controller.mm:121: [self.maskView setAlpha:1]; On 2016/12/20 16:31:44, Olivier Robin wrote: > Is this needed? > Will this not also fade in ? The dark background view will fade in and the extension view will slide up.
lgtm
The CQ bit was checked by gambard@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1482252240730450,
"parent_rev": "e5fdfc8840b1061018f3fa7f577bf06d010cfa62", "commit_rev":
"742df65880a1e963e0638226dff9aea6bde2d2e4"}
Message was sent while issue was closed.
Description was changed from ========== Tweak the share screen animation Change the share view animation from fade in/slide up to slide up/slide down. BUG=672773 ========== to ========== Tweak the share screen animation Change the share view animation from fade in/slide up to slide up/slide down. BUG=672773 Review-Url: https://codereview.chromium.org/2593563002 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Tweak the share screen animation Change the share view animation from fade in/slide up to slide up/slide down. BUG=672773 Review-Url: https://codereview.chromium.org/2593563002 ========== to ========== Tweak the share screen animation Change the share view animation from fade in/slide up to slide up/slide down. BUG=672773 Committed: https://crrev.com/b1309cfb4d2c0d22a5caeef6cd8883dd801250fb Cr-Commit-Position: refs/heads/master@{#439826} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/b1309cfb4d2c0d22a5caeef6cd8883dd801250fb Cr-Commit-Position: refs/heads/master@{#439826} |
