Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Issue 2593553002: [crankshaft] Ensure that we use inlined Array.prototype.shift only when there's no elements in the … (Closed)

Created:
4 years ago by Igor Sheludko
Modified:
4 years ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[crankshaft] Ensure that we use inlined Array.prototype.shift only when there's no elements in the prototype chain. BUG=chromium:663340 Review-Url: https://codereview.chromium.org/2593553002 Cr-Commit-Position: refs/heads/master@{#41846} Committed: https://chromium.googlesource.com/v8/v8/+/faf80b4ec0b5a901eecd77b7b356f2b0fe2ca4f7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -9 lines) Patch
M src/crankshaft/hydrogen.h View 2 chunks +5 lines, -2 lines 0 comments Download
M src/crankshaft/hydrogen.cc View 4 chunks +36 lines, -7 lines 0 comments Download
M src/prototype.h View 1 chunk +1 line, -0 lines 0 comments Download
A test/mjsunit/regress/regress-crbug-663340.js View 1 chunk +32 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
Igor Sheludko
PTAL
4 years ago (2016-12-20 09:48:56 UTC) #4
Benedikt Meurer
lgtm
4 years ago (2016-12-20 09:51:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2593553002/1
4 years ago (2016-12-20 10:16:38 UTC) #8
commit-bot: I haz the power
4 years ago (2016-12-20 10:18:06 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/faf80b4ec0b5a901eecd77b7b356f2b0fe2...

Powered by Google App Engine
This is Rietveld 408576698