Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 2593543002: Revert of Turn on icu_case_mapping by default (Closed)

Created:
4 years ago by Michael Achenbach
Modified:
4 years ago
CC:
v8-reviews_googlegroups.com, Michael Hablich
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Turn on icu_case_mapping by default (patchset #3 id:40001 of https://codereview.chromium.org/2588963002/ ) Reason for revert: Causes gc stress failures: https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20GC%20Stress%20-%20custom%20snapshot/builds/9920 Original issue's description: > Turn on icu_case_mapping by default > > BUG=v8:4477, v8:4476 > TEST=test262/{built-ins,intl402}/Strings/*, webkit/fast/js/*, > mjsunit/string-case, intl/general/case* > > Review-Url: https://codereview.chromium.org/2588963002 > Cr-Commit-Position: refs/heads/master@{#41834} > Committed: https://chromium.googlesource.com/v8/v8/+/7c79e23c34ea971947eedc6e42d8a882617c0e47 TBR=littledan@chromium.org,yangguo@chromium.org,jshin@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4477, v8:4476 Review-Url: https://codereview.chromium.org/2593543002 Cr-Commit-Position: refs/heads/master@{#41835} Committed: https://chromium.googlesource.com/v8/v8/+/f6d8ec4fca8952b4c14e91d7f5018a1f2fcfa64f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -14 lines) Patch
M src/flag-definitions.h View 1 chunk +5 lines, -12 lines 0 comments Download
M test/webkit/fast/js/string-capitalization-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Michael Achenbach
Created Revert of Turn on icu_case_mapping by default
4 years ago (2016-12-20 09:28:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2593543002/1
4 years ago (2016-12-20 09:28:29 UTC) #3
commit-bot: I haz the power
4 years ago (2016-12-20 09:28:40 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/f6d8ec4fca8952b4c14e91d7f5018a1f2fc...

Powered by Google App Engine
This is Rietveld 408576698