|
|
Chromium Code Reviews
DescriptionAdd page flip completion event to trace on CrOS
This patch adds CrOS page flip completion event to trace. The event has a timestamp
in data field, which is the exact time the page flip happened. It will be used to
improve smoothness display stats accuracy on CrOS.
BUG=675846
Review-Url: https://codereview.chromium.org/2593513002
Cr-Commit-Position: refs/heads/master@{#445659}
Committed: https://chromium.googlesource.com/chromium/src/+/433217209fecf0efddb8f511b74c749d3a55709b
Patch Set 1 #Messages
Total messages: 22 (12 generated)
Description was changed from ========== Add page flip completion event to trace on CrOS This patch adds CrOS page flip completion event to trace. The event has a timestamp in data field, which is the exact time the page flip happened. It will be used to improve smoothness display stats accuracy on CrOS. BUG=675846 ========== to ========== Add page flip completion event to trace on CrOS This patch adds CrOS page flip completion event to trace. The event has a timestamp in data field, which is the exact time the page flip happened. It will be used to improve smoothness display stats accuracy on CrOS. BUG=675846 ==========
zheda.chen@intel.com changed reviewers: + brianderson@chromium.org, marcheu@chromium.org, tdresser@chromium.org
zheda.chen@intel.com changed reviewers: + bccheng@chromium.org, llozano@chromium.org
On 2016/12/20 08:17:21, RafaelC wrote: This is one CL in a set of two: - https://codereview.chromium.org/2593513002/ (this one) - https://codereview.chromium.org/2594573002/ Please take a look, thanks!
spang@chromium.org changed reviewers: + spang@chromium.org
lgtm
Description was changed from ========== Add page flip completion event to trace on CrOS This patch adds CrOS page flip completion event to trace. The event has a timestamp in data field, which is the exact time the page flip happened. It will be used to improve smoothness display stats accuracy on CrOS. BUG=675846 ========== to ========== Add page flip completion event to trace on CrOS This patch adds CrOS page flip completion event to trace. The event has a timestamp in data field, which is the exact time the page flip happened. It will be used to improve smoothness display stats accuracy on CrOS. BUG=675846 ==========
Description was changed from ========== Add page flip completion event to trace on CrOS This patch adds CrOS page flip completion event to trace. The event has a timestamp in data field, which is the exact time the page flip happened. It will be used to improve smoothness display stats accuracy on CrOS. BUG=675846 ========== to ========== Add page flip completion event to trace on CrOS This patch adds CrOS page flip completion event to trace. The event has a timestamp in data field, which is the exact time the page flip happened. It will be used to improve smoothness display stats accuracy on CrOS. BUG=675846 ==========
Reviewers list updated. Please take a look, thanks
The CQ bit was checked by spang@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
The author zheda.chen@intel.com has not signed Google Contributor License Agreement. Please visit https://cla.developers.google.com to sign and manage CLA.
On 2017/01/05 18:05:39, commit-bot: I haz the power wrote: > The author mailto:zheda.chen@intel.com has not signed Google Contributor License > Agreement. Please visit https://cla.developers.google.com to sign and manage > CLA. I have submitted the CLA request and now wait for approval.
On 2017/01/09 07:34:48, RafaelC wrote: > > I have submitted the CLA request and now wait for approval. Unfortunately, the original staff in charge of processing CLA request has left intel, we are trying to find a right person to deal with this. Sorry for the convenience.
The CQ bit was checked by zheda.chen@intel.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1485235178040200, "parent_rev":
"5488d0abc4a664aefb1e65f883bacea353523dba", "commit_rev":
"433217209fecf0efddb8f511b74c749d3a55709b"}
Message was sent while issue was closed.
Description was changed from ========== Add page flip completion event to trace on CrOS This patch adds CrOS page flip completion event to trace. The event has a timestamp in data field, which is the exact time the page flip happened. It will be used to improve smoothness display stats accuracy on CrOS. BUG=675846 ========== to ========== Add page flip completion event to trace on CrOS This patch adds CrOS page flip completion event to trace. The event has a timestamp in data field, which is the exact time the page flip happened. It will be used to improve smoothness display stats accuracy on CrOS. BUG=675846 Review-Url: https://codereview.chromium.org/2593513002 Cr-Commit-Position: refs/heads/master@{#445659} Committed: https://chromium.googlesource.com/chromium/src/+/433217209fecf0efddb8f511b74c... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/433217209fecf0efddb8f511b74c... |
