[MD settings] remove action menu from all-sites

chrome/browser/resources/settings/site_settings/site_list.js

Index: chrome/browser/resources/settings/site_settings/site_list.js
diff --git a/chrome/browser/resources/settings/site_settings/site_list.js b/chrome/browser/resources/settings/site_settings/site_list.js
index 9564724efad82dcacfda949e6d5c3fc29b7e5182..bffe5019eb013d759be2c210dc8aec77396848e6 100644
--- a/chrome/browser/resources/settings/site_settings/site_list.js
+++ b/chrome/browser/resources/settings/site_settings/site_list.js
@@ -202,8 +202,8 @@ Polymer({
    * @return {boolean}
    * @private
    */
-  shouldShowMenu_: function(source) {
-    return !(this.isExceptionControlled_(source) || this.allSites);
+  isActionMenuHidden_: function(source) {

[dpapad, 2016/12/21 01:30:59]

So it seems shouldShowMenu_ was dead code previously? Looking at the history,
last usage was removed at https://codereview.chromium.org/2386993005, but the
function itself was not removed (and I did not catch this in review).

[dschuyler, 2016/12/21 02:06:47]

That appears to be so.
Not a big deal.

+    return this.isExceptionControlled_(source) || this.allSites;
   },
 
   /**