Site Settings Desktop: Switch out paper-menu for iron-dropdown.

Site Settings Desktop: Switch out Site-List paper-menu for iron-dropdown.

BUG=629920, 625805
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/0f6bea6b3b13dc044d18813348c1137d0d0b51bc
Cr-Commit-Position: refs/heads/master@{#423228}

[Finnur, 2016-10-04 13:18:23]

Description was changed from

==========
Site Settings Desktop: Switch out paper-menu for iron-dropdown.

BUG=629920, 625805
==========

to

==========
Site Settings Desktop: Switch out paper-menu for iron-dropdown.

BUG=629920, 625805
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Finnur, 2016-10-04 13:18:34]

The CQ bit was checked by finnur@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-04 13:18:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Finnur, 2016-10-04 13:19:12]

finnur@chromium.org changed reviewers:
+ dpapad@chromium.org

[Finnur, 2016-10-04 13:19:31]

Description was changed from

==========
Site Settings Desktop: Switch out paper-menu for iron-dropdown.

BUG=629920, 625805
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Site Settings Desktop: Switch out Site-List paper-menu for iron-dropdown.

BUG=629920, 625805
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-10-04 13:21:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-04 13:21:43]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Finnur, 2016-10-04 17:06:03]

The CQ bit was checked by finnur@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-04 17:06:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-04 17:52:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-04 17:52:18]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dpapad, 2016-10-04 20:58:45]

https://codereview.chromium.org/2386993005/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/site_settings/site_list.html (right):

https://codereview.chromium.org/2386993005/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/site_settings/site_list.html:8: <link
rel="import"
href="chrome://resources/polymer/v1_0/paper-icon-button/paper-icon-button-light.html">
Is this used anymore?

https://codereview.chromium.org/2386993005/diff/20001/chrome/test/data/webui/...
File chrome/test/data/webui/settings/site_list_tests.js (right):

https://codereview.chromium.org/2386993005/diff/20001/chrome/test/data/webui/...
chrome/test/data/webui/settings/site_list_tests.js:330: 'iron-dropdown div
button:not([hidden])');
Does this selector have to be so specific? How about

'iron-dropdown .dropdown-item:not([hidden])'

https://codereview.chromium.org/2386993005/diff/20001/chrome/test/data/webui/...
chrome/test/data/webui/settings/site_list_tests.js:338: function
openContextMenu(index) {
Nit: We've been trying to establish the term "action" menu, for all the menus
that open when clicking on a dots icon.

[Finnur, 2016-10-05 10:18:52]

The CQ bit was checked by finnur@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-05 10:19:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Finnur, 2016-10-05 10:29:43]

PTAL.

https://codereview.chromium.org/2386993005/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/site_settings/site_list.html (right):

https://codereview.chromium.org/2386993005/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/site_settings/site_list.html:8: <link
rel="import"
href="chrome://resources/polymer/v1_0/paper-icon-button/paper-icon-button-light.html">
Nope, gone.

https://codereview.chromium.org/2386993005/diff/20001/chrome/test/data/webui/...
File chrome/test/data/webui/settings/site_list_tests.js (right):

https://codereview.chromium.org/2386993005/diff/20001/chrome/test/data/webui/...
chrome/test/data/webui/settings/site_list_tests.js:330: 'iron-dropdown div
button:not([hidden])');
Works for me.

https://codereview.chromium.org/2386993005/diff/20001/chrome/test/data/webui/...
chrome/test/data/webui/settings/site_list_tests.js:338: function
openContextMenu(index) {
On 2016/10/04 20:58:44, dpapad wrote:
> Nit: We've been trying to establish the term "action" menu, for all the menus
> that open when clicking on a dots icon.

Done.

[commit-bot: I haz the power, 2016-10-05 12:09:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-05 12:09:03]

Dry run: This issue passed the CQ dry run.

[dpapad, 2016-10-05 16:37:43]

lgtm

[Finnur, 2016-10-05 18:19:21]

The CQ bit was checked by finnur@chromium.org

[commit-bot: I haz the power, 2016-10-05 18:19:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-05 18:27:36]

Description was changed from

==========
Site Settings Desktop: Switch out Site-List paper-menu for iron-dropdown.

BUG=629920, 625805
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Site Settings Desktop: Switch out Site-List paper-menu for iron-dropdown.

BUG=629920, 625805
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-10-05 18:27:38]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-05 18:31:01]

Description was changed from

==========
Site Settings Desktop: Switch out Site-List paper-menu for iron-dropdown.

BUG=629920, 625805
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Site Settings Desktop: Switch out Site-List paper-menu for iron-dropdown.

BUG=629920, 625805
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/0f6bea6b3b13dc044d18813348c1137d0d0b51bc
Cr-Commit-Position: refs/heads/master@{#423228}
==========

[commit-bot: I haz the power, 2016-10-05 18:31:02]

Patchset 3 (id:??) landed as
https://crrev.com/0f6bea6b3b13dc044d18813348c1137d0d0b51bc
Cr-Commit-Position: refs/heads/master@{#423228}