[MD settings] remove action menu from all-sites

chrome/browser/resources/settings/site_settings/site_list.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * Enumeration mapping all possible controlled-by values for exceptions to
  * icons.
  * @enum {string}
  */
 var iconControlledBy = {
@@ skipping 184 matching lines @@
    */
   hasSites_: function() {
     return !!this.sites.length;
   },
 
   /**
    * @param {string} source Where the setting came from.
    * @return {boolean}
    * @private
    */
-  shouldShowMenu_: function(source) {
-    return !(this.isExceptionControlled_(source) || this.allSites);
+  isActionMenuHidden_: function(source) {

[dpapad, 2016/12/21 01:30:59]

So it seems shouldShowMenu_ was dead code previously? Looking at the history,
last usage was removed at https://codereview.chromium.org/2386993005, but the
function itself was not removed (and I did not catch this in review).

[dschuyler, 2016/12/21 02:06:47]

That appears to be so.
Not a big deal.

+    return this.isExceptionControlled_(source) || this.allSites;
   },
 
   /**
    * A handler for the Add Site button.
    * @param {!Event} e
    * @private
    */
   onAddSiteTap_: function(e) {
     e.preventDefault();
     var dialog = document.createElement('add-site-dialog');
@@ skipping 255 matching lines @@
                 Polymer.dom(/** @type {!Event} */ (e)).localTarget));
   },
 
   /** @private */
   closeActionMenu_: function() {
     this.actionMenuSite_ = null;
     /** @type {!CrActionMenuElement} */ (
         this.$$('dialog[is=cr-action-menu]')).close();
   },
 });