Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Issue 2593333004: Revert of Enable no-compile tests on linux clang (Closed)

Created:
4 years ago by Nico
Modified:
4 years ago
Reviewers:
jbudorick, dcheng, wychen
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Enable no-compile tests on linux clang (patchset #1 id:1 of https://codereview.chromium.org/2594943002/ ) Reason for revert: Doesn't build everywhere, see https://crbug.com/676649 Original issue's description: > Enable no-compile tests on linux clang > > BUG=105388 > > Committed: https://crrev.com/7a9a5838fe86ec2de95e61adb4cabe959663b8b2 > Cr-Commit-Position: refs/heads/master@{#440384} TBR=dcheng@chromium.org,jbudorick@chromium.org,wychen@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=105388 Committed: https://crrev.com/de864efb596ca3df1a6df84a67f110221fb7bcaf Cr-Commit-Position: refs/heads/master@{#440438}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M build/nocompile.gni View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Nico
Created Revert of Enable no-compile tests on linux clang
4 years ago (2016-12-22 16:34:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2593333004/1
4 years ago (2016-12-22 16:34:43 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-22 16:36:20 UTC) #6
commit-bot: I haz the power
4 years ago (2016-12-22 16:40:17 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/de864efb596ca3df1a6df84a67f110221fb7bcaf
Cr-Commit-Position: refs/heads/master@{#440438}

Powered by Google App Engine
This is Rietveld 408576698