Replace TabStripTest.TabHitTestMaskWhenStacked with something more meaningful.

Replace TabStripTest.TabHitTestMaskWhenStacked with something more meaningful.

The old test checked the hit test results for individual tabs.  This assumed
that hitboxes for partly-occluded stacked tabs would themselves be partly
occluded, and basically verified that this occlusion made sense.

We changed this in r411197.  Now, individual tab hitboxes are the full size of
the tab, and instead tab occlusion is handled by functions like
FindTabForEvent(), which check tabs in the correct order.

The new test simply iterates across the tabstrip at three vertical positions,
checking what every pixel hits, and making sure the order (in tab model indexes)
of what's hit is:

-1 0 1 2 3 -1

I dunno that this is a very robust test, but I don't think we really had
anything else testing event handling for stacked tabs at all, so it seemed
better than deleting the test entirely.

BUG=575327
TEST=none

Committed: https://crrev.com/a067fd9d9e552c2c12a786bd857aa21a4de147aa
Cr-Commit-Position: refs/heads/master@{#441417}

[Peter Kasting, 2016-12-21 23:27:14]

pkasting@chromium.org changed reviewers:
+ sky@chromium.org

[sky, 2017-01-03 22:04:02]

LGTM

[Peter Kasting, 2017-01-04 17:36:26]

The CQ bit was checked by pkasting@chromium.org

[Peter Kasting, 2017-01-04 17:36:26]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2593273002/#ps20001
(title: "Resync")

[commit-bot: I haz the power, 2017-01-04 17:36:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-04 18:41:44]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1483551386038480,
"parent_rev": "c7eede0ca995433085b8cd9bdada9aaf7bc25ad8", "commit_rev":
"710f86aeb85758a2857d545f7e1808005161d314"}

[commit-bot: I haz the power, 2017-01-04 18:42:15]

Description was changed from

==========
Replace TabStripTest.TabHitTestMaskWhenStacked with something more meaningful.

The old test checked the hit test results for individual tabs.  This assumed
that hitboxes for partly-occluded stacked tabs would themselves be partly
occluded, and basically verified that this occlusion made sense.

We changed this in r411197.  Now, individual tab hitboxes are the full size of
the tab, and instead tab occlusion is handled by functions like
FindTabForEvent(), which check tabs in the correct order.

The new test simply iterates across the tabstrip at three vertical positions,
checking what every pixel hits, and making sure the order (in tab model indexes)
of what's hit is:

-1 0 1 2 3 -1

I dunno that this is a very robust test, but I don't think we really had
anything else testing event handling for stacked tabs at all, so it seemed
better than deleting the test entirely.

BUG=575327
TEST=none
==========

to

==========
Replace TabStripTest.TabHitTestMaskWhenStacked with something more meaningful.

The old test checked the hit test results for individual tabs.  This assumed
that hitboxes for partly-occluded stacked tabs would themselves be partly
occluded, and basically verified that this occlusion made sense.

We changed this in r411197.  Now, individual tab hitboxes are the full size of
the tab, and instead tab occlusion is handled by functions like
FindTabForEvent(), which check tabs in the correct order.

The new test simply iterates across the tabstrip at three vertical positions,
checking what every pixel hits, and making sure the order (in tab model indexes)
of what's hit is:

-1 0 1 2 3 -1

I dunno that this is a very robust test, but I don't think we really had
anything else testing event handling for stacked tabs at all, so it seemed
better than deleting the test entirely.

BUG=575327
TEST=none

Review-Url: https://codereview.chromium.org/2593273002
==========

[commit-bot: I haz the power, 2017-01-04 18:42:16]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2017-01-04 18:44:28]

Description was changed from

==========
Replace TabStripTest.TabHitTestMaskWhenStacked with something more meaningful.

The old test checked the hit test results for individual tabs.  This assumed
that hitboxes for partly-occluded stacked tabs would themselves be partly
occluded, and basically verified that this occlusion made sense.

We changed this in r411197.  Now, individual tab hitboxes are the full size of
the tab, and instead tab occlusion is handled by functions like
FindTabForEvent(), which check tabs in the correct order.

The new test simply iterates across the tabstrip at three vertical positions,
checking what every pixel hits, and making sure the order (in tab model indexes)
of what's hit is:

-1 0 1 2 3 -1

I dunno that this is a very robust test, but I don't think we really had
anything else testing event handling for stacked tabs at all, so it seemed
better than deleting the test entirely.

BUG=575327
TEST=none

Review-Url: https://codereview.chromium.org/2593273002
==========

to

==========
Replace TabStripTest.TabHitTestMaskWhenStacked with something more meaningful.

The old test checked the hit test results for individual tabs.  This assumed
that hitboxes for partly-occluded stacked tabs would themselves be partly
occluded, and basically verified that this occlusion made sense.

We changed this in r411197.  Now, individual tab hitboxes are the full size of
the tab, and instead tab occlusion is handled by functions like
FindTabForEvent(), which check tabs in the correct order.

The new test simply iterates across the tabstrip at three vertical positions,
checking what every pixel hits, and making sure the order (in tab model indexes)
of what's hit is:

-1 0 1 2 3 -1

I dunno that this is a very robust test, but I don't think we really had
anything else testing event handling for stacked tabs at all, so it seemed
better than deleting the test entirely.

BUG=575327
TEST=none

Committed: https://crrev.com/a067fd9d9e552c2c12a786bd857aa21a4de147aa
Cr-Commit-Position: refs/heads/master@{#441417}
==========

[commit-bot: I haz the power, 2017-01-04 18:44:29]

Patchset 2 (id:??) landed as
https://crrev.com/a067fd9d9e552c2c12a786bd857aa21a4de147aa
Cr-Commit-Position: refs/heads/master@{#441417}