Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 2593163002: remove some CFX_ArrayTemplate in xfa_ffdocview.h (Closed)

Created:
3 years, 12 months ago by Tom Sepez
Modified:
3 years, 11 months ago
Reviewers:
Lei Zhang, dsinclair
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : duplicate code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -68 lines) Patch
M xfa/fxfa/app/xfa_ffdocview.cpp View 1 7 chunks +58 lines, -62 lines 0 comments Download
M xfa/fxfa/app/xfa_ffnotify.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/xfa_ffdocview.h View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 18 (12 generated)
Tom Sepez
3 years, 12 months ago (2016-12-21 21:12:46 UTC) #6
dsinclair
https://codereview.chromium.org/2593163002/diff/1/xfa/fxfa/app/xfa_ffdocview.cpp File xfa/fxfa/app/xfa_ffdocview.cpp (right): https://codereview.chromium.org/2593163002/diff/1/xfa/fxfa/app/xfa_ffdocview.cpp#newcode648 xfa/fxfa/app/xfa_ffdocview.cpp:648: CXFA_WidgetAcc* pCurrentAcc = What about just doing: AddCalculateWidgetAcc(pResultAcc) here ...
3 years, 11 months ago (2017-01-02 17:47:13 UTC) #8
Tom Sepez
https://codereview.chromium.org/2593163002/diff/1/xfa/fxfa/app/xfa_ffdocview.cpp File xfa/fxfa/app/xfa_ffdocview.cpp (right): https://codereview.chromium.org/2593163002/diff/1/xfa/fxfa/app/xfa_ffdocview.cpp#newcode648 xfa/fxfa/app/xfa_ffdocview.cpp:648: CXFA_WidgetAcc* pCurrentAcc = On 2017/01/02 17:47:13, dsinclair wrote: > ...
3 years, 11 months ago (2017-01-03 22:04:03 UTC) #11
dsinclair
lgtm
3 years, 11 months ago (2017-01-03 22:06:44 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2593163002/20001
3 years, 11 months ago (2017-01-03 22:08:20 UTC) #15
commit-bot: I haz the power
3 years, 11 months ago (2017-01-03 22:18:11 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/d654d7854951e0ed3589fcc34617c7ca593d...

Powered by Google App Engine
This is Rietveld 408576698