Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 2593133002: Revert of Add account_type into AccountId (Closed)

Created:
4 years ago by hcarmona
Modified:
4 years ago
CC:
chromium-reviews, dbeam+watch-options_chromium.org, alemate+watch_chromium.org, achuith+watch_chromium.org, michaelpg+watch-options_chromium.org, pam+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add account_type into AccountId (patchset #10 id:180001 of https://codereview.chromium.org/2529103002/ ) Reason for revert: Causing build failure: https://uberchromegw.corp.google.com/i/chromium/builders/Linux%20x64/builds/30384 Original issue's description: > Add account_type into AccountId > > - Add Active Directory type account > - Rename gaia_id_ to id_. > - Add |AcccountType| param to user_manager::known_user::GetAccountId > - Add |AdFromUserEmailObjGuid| |AdFromUserEmail| functions to create Active Directory account ids. > > This CL a preparation for crbug.com/668130 > Should be fixed after migration (see crbug.com/668130) > > BUG=656992 > TEST=none > > Committed: https://crrev.com/d297d94d7922ac0ebd6ca1f3db3fff6db3af24b9 > Cr-Commit-Position: refs/heads/master@{#440152} TBR=alemate@chromium.org,stevenjb@chromium.org,atwilson@chromium.org,rogerta@chromium.org,rsorokin@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=656992 Committed: https://crrev.com/314e8f11777388068b8d07c83d664437da7da52a Cr-Commit-Position: refs/heads/master@{#440173}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+141 lines, -412 lines) Patch
M chrome/browser/chromeos/login/easy_unlock/bootstrap_manager.cc View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/chromeos/login/easy_unlock/bootstrap_user_context_initializer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/easy_unlock/easy_unlock_tpm_key_manager_factory.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/screens/chrome_user_selection_screen.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/screens/user_selection_screen.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/session/user_session_manager.cc View 1 chunk +5 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/supervised/supervised_user_authenticator.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc View 5 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos_unittest.cc View 1 chunk +3 lines, -6 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc View 6 chunks +10 lines, -12 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/user_image_source.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/cryptohome/cryptohome_parameters.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chromeos/login/auth/cryptohome_authenticator.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chromeos/tpm/tpm_token_info_getter_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/signin/core/account_id/account_id.h View 3 chunks +4 lines, -34 lines 0 comments Download
M components/signin/core/account_id/account_id.cc View 5 chunks +52 lines, -180 lines 0 comments Download
M components/user_manager/known_user.h View 3 chunks +1 line, -7 lines 0 comments Download
M components/user_manager/known_user.cc View 6 chunks +32 lines, -133 lines 0 comments Download
M components/user_manager/user_manager_base.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
hcarmona
Created Revert of Add account_type into AccountId
4 years ago (2016-12-21 19:14:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2593133002/1
4 years ago (2016-12-21 19:14:59 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-21 19:16:53 UTC) #6
commit-bot: I haz the power
4 years ago (2016-12-21 19:18:46 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/314e8f11777388068b8d07c83d664437da7da52a
Cr-Commit-Position: refs/heads/master@{#440173}

Powered by Google App Engine
This is Rietveld 408576698