sdk/lib/collection/list.dart - Issue 25931003: Make List.shuffle take an optional Random object to use.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/collection/list.dart

Issue 25931003: Make List.shuffle take an optional Random object to use. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Address comment. Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sdk/lib/collection/list.dart

diff --git a/sdk/lib/collection/list.dart b/sdk/lib/collection/list.dart

index 74cda1df9427ac81e091679df912bba3f770520a..eed6b32cefb5966d4803b52e881d8b85e1401697 100644

--- a/sdk/lib/collection/list.dart

+++ b/sdk/lib/collection/list.dart

@@ -301,8 +301,8 @@ abstract class ListMixin<E> implements List<E> {

Sort.sort(this, compare);

}

- void shuffle() {

- Random random = new Random();

+ void shuffle([Random random]) {

+ if (random == null) random = new Random();

int length = this.length;

while (length > 1) {

int pos = random.nextInt(length);

« no previous file with comments | « sdk/lib/_internal/lib/js_array.dart ('k') | sdk/lib/core/core.dart » ('j') | no next file with comments »