Convert audiobuffersource-channels to testharness

Convert audiobuffersource-channels to testharness

Manually convert test to use testharness

BUG=676394
TEST=audiobuffersource-channels.html

Committed: https://crrev.com/cf3e84267fa10b298f7f4f9d53d6d11de9affd11
Cr-Commit-Position: refs/heads/master@{#441508}

[Raymond Toy, 2017-01-03 22:25:39]

Description was changed from

==========
Convert AudioBufferSource tests to testharness

Manually convert test to use testharness

BUG=676394
TEST=audiobuffersource-channels.html
==========

to

==========
Convert audiobuffersource-channels to testharness

Manually convert test to use testharness

BUG=676394
TEST=audiobuffersource-channels.html
==========

[Raymond Toy, 2017-01-03 23:49:45]

The CQ bit was checked by rtoy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-03 23:50:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-04 01:21:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-04 01:21:55]

Dry run: This issue passed the CQ dry run.

[Raymond Toy, 2017-01-04 19:10:21]

rtoy@chromium.org changed reviewers:
+ hongchan@chromium.org

[Raymond Toy, 2017-01-04 19:10:22]

PTAL

[hongchan, 2017-01-04 21:50:11]

lgtm with nit

https://codereview.chromium.org/2593083003/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiobuffersource-channels.html
(right):

https://codereview.chromium.org/2593083003/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiobuffersource-channels.html:18:
"AudioBufferSourceNode validates AudioBuffer in .buffer attribute setter",
I don't think this is the intended usage. Can we use task.describe() for the
longer description? The argument for .define() is for the short task label.

[Raymond Toy, 2017-01-04 22:24:37]

https://codereview.chromium.org/2593083003/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiobuffersource-channels.html
(right):

https://codereview.chromium.org/2593083003/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiobuffersource-channels.html:18:
"AudioBufferSourceNode validates AudioBuffer in .buffer attribute setter",
On 2017/01/04 21:50:11, hongchan wrote:
> I don't think this is the intended usage. Can we use task.describe() for the
> longer description? The argument for .define() is for the short task label.

Done.

[Raymond Toy, 2017-01-04 22:27:54]

The CQ bit was checked by rtoy@chromium.org

[Raymond Toy, 2017-01-04 22:27:55]

The patchset sent to the CQ was uploaded after l-g-t-m from
hongchan@chromium.org
Link to the patchset: https://codereview.chromium.org/2593083003/#ps60001
(title: "Address review comments.")

[commit-bot: I haz the power, 2017-01-04 22:28:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-04 23:33:49]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1483568874697610,
"parent_rev": "804d37a35091c871ad49adb54598774731e68ebe", "commit_rev":
"e7c15d781e5e1d3893ce1af06f10a5c3dd9dae88"}

[commit-bot: I haz the power, 2017-01-04 23:34:15]

Description was changed from

==========
Convert audiobuffersource-channels to testharness

Manually convert test to use testharness

BUG=676394
TEST=audiobuffersource-channels.html
==========

to

==========
Convert audiobuffersource-channels to testharness

Manually convert test to use testharness

BUG=676394
TEST=audiobuffersource-channels.html

Review-Url: https://codereview.chromium.org/2593083003
==========

[commit-bot: I haz the power, 2017-01-04 23:34:16]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2017-01-04 23:38:41]

Description was changed from

==========
Convert audiobuffersource-channels to testharness

Manually convert test to use testharness

BUG=676394
TEST=audiobuffersource-channels.html

Review-Url: https://codereview.chromium.org/2593083003
==========

to

==========
Convert audiobuffersource-channels to testharness

Manually convert test to use testharness

BUG=676394
TEST=audiobuffersource-channels.html

Committed: https://crrev.com/cf3e84267fa10b298f7f4f9d53d6d11de9affd11
Cr-Commit-Position: refs/heads/master@{#441508}
==========

[commit-bot: I haz the power, 2017-01-04 23:38:42]

Patchset 4 (id:??) landed as
https://crrev.com/cf3e84267fa10b298f7f4f9d53d6d11de9affd11
Cr-Commit-Position: refs/heads/master@{#441508}