Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 2593083002: Convert AudioBuffer Audit tests to testharness (Closed)

Created:
3 years, 12 months ago by Raymond Toy
Modified:
3 years, 11 months ago
Reviewers:
hongchan
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert AudioBuffer Audit tests to testharness Only the tests using Audit are converted here, using the script: for f in `grep -l Audit *.html` do # Replace js-test with testharness and add testharnessreport.js sed -i 's;\(.*\)\(<script.*\)js-test.js\(.*\);\1\2testharness.js\3\ \1\2testharnessreport.js\3 ;' $f # Remove old js-test methods that no longer exist. sed -i '/^[ ]*\(description(".*")\|finishJSTest()\);[ ]*/d' $f # Remove jsTestIsAsync stuff sed -i '/^[ ]*window.jsTestIsAsync *= *true;[ ]*$/d' $f done Additional manual changes were needed to replace methods defined by js-test. Expected results files also removed. BUG=676355 TEST=audiobuffer-copy-channel.html, audiobuffer-getChannelData.html Committed: https://crrev.com/01758e7540a3f0412d08edaa5253f94a3c7d9a9a Cr-Commit-Position: refs/heads/master@{#441383}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -111 lines) Patch
M third_party/WebKit/LayoutTests/webaudio/AudioBuffer/audiobuffer-copy-channel.html View 1 6 chunks +14 lines, -8 lines 0 comments Download
D third_party/WebKit/LayoutTests/webaudio/AudioBuffer/audiobuffer-copy-channel-expected.txt View 1 chunk +0 lines, -48 lines 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/AudioBuffer/audiobuffer-getChannelData.html View 1 4 chunks +21 lines, -30 lines 0 comments Download
D third_party/WebKit/LayoutTests/webaudio/AudioBuffer/audiobuffer-getChannelData-expected.txt View 1 chunk +0 lines, -25 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
Raymond Toy
PTAL
3 years, 11 months ago (2017-01-04 00:14:39 UTC) #7
hongchan
lgtm
3 years, 11 months ago (2017-01-04 00:34:36 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2593083002/20001
3 years, 11 months ago (2017-01-04 16:07:48 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
3 years, 11 months ago (2017-01-04 16:12:17 UTC) #13
commit-bot: I haz the power
3 years, 11 months ago (2017-01-04 16:14:02 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/01758e7540a3f0412d08edaa5253f94a3c7d9a9a
Cr-Commit-Position: refs/heads/master@{#441383}

Powered by Google App Engine
This is Rietveld 408576698