Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2593013002:
Modify Mali Workaround patch for the latest Mali GPU (Closed)
DescriptionModify Mali Workaround patch for the latest Mali GPU
Modify the list based on the latest Mali GPU
https://www.arm.com/products/graphics-and-multimedia/mali-gpu
BUG=NA
Signed-off-by: sujiths.s <sujiths.s@samsung.com>;
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Committed: https://crrev.com/0b31cc6059ad4cecb1e29acaf0e2eacb017a9607
Cr-Commit-Position: refs/heads/master@{#440744}
Patch Set 1 #
Messages
Total messages: 20 (9 generated)
Description was changed from ========== Modify Mali Workaround patch for the latest Mali GPU Modify the list based on the latest Mali GPU https://www.arm.com/products/graphics-and-multimedia/mali-gpu BUG=NA Signed-off-by: sujiths.s <sujiths.s@samsung.com> ========== to ========== Modify Mali Workaround patch for the latest Mali GPU Modify the list based on the latest Mali GPU https://www.arm.com/products/graphics-and-multimedia/mali-gpu BUG=NA Signed-off-by: sujiths.s <sujiths.s@samsung.com> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
sujiths.s@samsung.com changed reviewers: + aelias@chromium.org
PTAL. Modifying the workaround list to support Mali-G71 https://www.arm.com/products/multimedia/mali-gpu/high-performance/mali-g71.php Currently supports only Mali-Txx series.
sujiths.s@samsung.com changed reviewers: + zmo@chromium.org
PTAL
On 2016/12/21 13:11:42, sujith wrote: > PTAL Have you tested that the latest Mali GPU also have the same problem as the Mali-T* GPUs?
On 2016/12/21 23:16:41, Zhenyao Mo wrote: > On 2016/12/21 13:11:42, sujith wrote: > > PTAL > > Have you tested that the latest Mali GPU also have the same problem as the > Mali-T* GPUs? Yes, I happens in G71 same as T series. I have tested, it works fine when we apply use_virtualized_gl_contexts workaround. flush ordering is not quaranteed same as all T series.
On 2016/12/22 05:23:16, KhNo wrote: > On 2016/12/21 23:16:41, Zhenyao Mo wrote: > > On 2016/12/21 13:11:42, sujith wrote: > > > PTAL > > > > Have you tested that the latest Mali GPU also have the same problem as the > > Mali-T* GPUs? > > Yes, I happens in G71 same as T series. > I have tested, it works fine when we apply use_virtualized_gl_contexts > workaround. > flush ordering is not quaranteed same as all T series. lgtm
Description was changed from ========== Modify Mali Workaround patch for the latest Mali GPU Modify the list based on the latest Mali GPU https://www.arm.com/products/graphics-and-multimedia/mali-gpu BUG=NA Signed-off-by: sujiths.s <sujiths.s@samsung.com> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Modify Mali Workaround patch for the latest Mali GPU Modify the list based on the latest Mali GPU https://www.arm.com/products/graphics-and-multimedia/mali-gpu BUG=NA Signed-off-by: sujiths.s <sujiths.s@samsung.com> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
keonho07.kim@samsung.com changed reviewers: + kbr@chromium.org, kbr@google.com
On 2016/12/22 17:59:34, Zhenyao Mo wrote: > On 2016/12/22 05:23:16, KhNo wrote: > > On 2016/12/21 23:16:41, Zhenyao Mo wrote: > > > On 2016/12/21 13:11:42, sujith wrote: > > > > PTAL > > > > > > Have you tested that the latest Mali GPU also have the same problem as the > > > Mali-T* GPUs? > > > > Yes, I happens in G71 same as T series. > > I have tested, it works fine when we apply use_virtualized_gl_contexts > > workaround. > > flush ordering is not quaranteed same as all T series. > > lgtm Dear Zhenyao Mo. Coould you help to trigger run trybot and merging. Is there required other OWNER +2?
The CQ bit was checked by sujiths.s@samsung.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1482823172639120, "parent_rev":
"2a8990804c053b15091ee04d0eceeb63d8e03d1d", "commit_rev":
"5a34a10bbdb4f86d1f2a143d6b841eded5b198e2"}
Message was sent while issue was closed.
Description was changed from ========== Modify Mali Workaround patch for the latest Mali GPU Modify the list based on the latest Mali GPU https://www.arm.com/products/graphics-and-multimedia/mali-gpu BUG=NA Signed-off-by: sujiths.s <sujiths.s@samsung.com> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Modify Mali Workaround patch for the latest Mali GPU Modify the list based on the latest Mali GPU https://www.arm.com/products/graphics-and-multimedia/mali-gpu BUG=NA Signed-off-by: sujiths.s <sujiths.s@samsung.com> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2593013002 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Modify Mali Workaround patch for the latest Mali GPU Modify the list based on the latest Mali GPU https://www.arm.com/products/graphics-and-multimedia/mali-gpu BUG=NA Signed-off-by: sujiths.s <sujiths.s@samsung.com> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2593013002 ========== to ========== Modify Mali Workaround patch for the latest Mali GPU Modify the list based on the latest Mali GPU https://www.arm.com/products/graphics-and-multimedia/mali-gpu BUG=NA Signed-off-by: sujiths.s <sujiths.s@samsung.com> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/0b31cc6059ad4cecb1e29acaf0e2eacb017a9607 Cr-Commit-Position: refs/heads/master@{#440744} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/0b31cc6059ad4cecb1e29acaf0e2eacb017a9607 Cr-Commit-Position: refs/heads/master@{#440744}
Message was sent while issue was closed.
Sorry, I was on vacation. This expansion seems unnecessarily broad to me. I don't want to churn behavior of the entire Mali fleet just for the sake of this new G-series, this will likely result in noise in perfbots and crash reports at a minimum. I'm reverting, please upload a new patch creating a new entry targeted to Mali-G* instead.
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2609003005/ by aelias@chromium.org. The reason for reverting is: "Sorry, I was on vacation. This expansion seems unnecessarily broad to me. I don't want to churn behavior of the entire Mali fleet just for the sake of this new G-series, this will likely result in noise in perfbots and crash reports at a minimum. I'm reverting, please upload a new patch creating a new entry targeted to Mali-G* instead.". |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
