Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 2592993002: PingLoaderImpl should use ContextClient instead of using WeakMember (Closed)

Created:
4 years ago by haraken
Modified:
4 years ago
Reviewers:
sof
CC:
chromium-reviews, blink-reviews, loading-reviews_chromium.org, tyoshino+watch_chromium.org, Nate Chapin, gavinp+loader_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

PingLoaderImpl should use ContextClient instead of using WeakMember PingLoaderImpl is expecting frame() to be cleared when the frame is detached. This means that it needs to be ContextClient. Using WeakMember<LocalFrame> is wrong because frame() is not cleared until the frame is gc-ed. BUG=610176 Committed: https://crrev.com/01c3564cde9cbaa8705f128337f3bed44c2d6ae3 Cr-Commit-Position: refs/heads/master@{#440085}

Patch Set 1 #

Patch Set 2 : temp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -17 lines) Patch
M third_party/WebKit/Source/core/loader/PingLoader.cpp View 1 8 chunks +19 lines, -17 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
haraken
PTAL (This is a correct reland of https://codereview.chromium.org/2569983002/)
4 years ago (2016-12-21 12:34:22 UTC) #2
sof
lgtm
4 years ago (2016-12-21 12:36:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2592993002/20001
4 years ago (2016-12-21 12:38:26 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-21 13:55:10 UTC) #8
commit-bot: I haz the power
4 years ago (2016-12-21 13:57:37 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/01c3564cde9cbaa8705f128337f3bed44c2d6ae3
Cr-Commit-Position: refs/heads/master@{#440085}

Powered by Google App Engine
This is Rietveld 408576698