chrome/browser/chromeos/policy/remote_commands/device_command_screenshot_job.cc - Issue 2592983002: [devtools] Support different encodings for Page.CaptureScreenshot.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/policy/remote_commands/device_command_screenshot_job.cc

Issue 2592983002: [devtools] Support different encodings for Page.CaptureScreenshot. (Closed)

Patch Set: Disabled test on MacOS >=10.11, added ref to bug. Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/policy/remote_commands/device_command_screenshot_job.h ('k') | chrome/browser/chromeos/policy/remote_commands/screenshot_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/policy/remote_commands/device_command_screenshot_job.cc

diff --git a/chrome/browser/chromeos/policy/remote_commands/device_command_screenshot_job.cc b/chrome/browser/chromeos/policy/remote_commands/device_command_screenshot_job.cc

index 2e0e156f143bef0fa6aabdcfe0ed8eeb7464c054..249f3d92b1583216110b3e1063c99ce8ac7cee1e 100644

--- a/chrome/browser/chromeos/policy/remote_commands/device_command_screenshot_job.cc

+++ b/chrome/browser/chromeos/policy/remote_commands/device_command_screenshot_job.cc

@@ -60,7 +60,7 @@ const char* const kUploadUrlFieldName = "fileUploadUrl";

void RunStoreScreenshotOnTaskRunner(

const ui::GrabWindowSnapshotAsyncPNGCallback& store_screenshot_callback,

scoped_refptr<base::TaskRunner> task_runner,

- scoped_refptr<base::RefCountedBytes> png_data) {

+ scoped_refptr<base::RefCountedMemory> png_data) {

task_runner->PostTask(FROM_HERE,

base::Bind(store_screenshot_callback, png_data));

}

@@ -157,7 +157,7 @@ bool DeviceCommandScreenshotJob::ParseCommandPayload(

void DeviceCommandScreenshotJob::StoreScreenshot(

size_t screen,

- scoped_refptr<base::RefCountedBytes> png_data) {

+ scoped_refptr<base::RefCountedMemory> png_data) {

screenshots_.insert(std::make_pair(screen, png_data));

DCHECK_LT(0, num_pending_screenshots_);

--num_pending_screenshots_;