chrome/browser/chromeos/policy/remote_commands/device_command_screenshot_job.h - Issue 2592983002: [devtools] Support different encodings for Page.CaptureScreenshot.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/policy/remote_commands/device_command_screenshot_job.h

Issue 2592983002: [devtools] Support different encodings for Page.CaptureScreenshot. (Closed)

Patch Set: Disabled test on MacOS >=10.11, added ref to bug. Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/login/screenshot_testing/screenshot_tester.cc ('k') | chrome/browser/chromeos/policy/remote_commands/device_command_screenshot_job.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/policy/remote_commands/device_command_screenshot_job.h

diff --git a/chrome/browser/chromeos/policy/remote_commands/device_command_screenshot_job.h b/chrome/browser/chromeos/policy/remote_commands/device_command_screenshot_job.h

index b1b588dd699c488c93b40f07007478a1f6bb2122..da124bd966287cd9bec20f69f963d4c044f89b46 100644

--- a/chrome/browser/chromeos/policy/remote_commands/device_command_screenshot_job.h

+++ b/chrome/browser/chromeos/policy/remote_commands/device_command_screenshot_job.h

@@ -110,7 +110,7 @@ class DeviceCommandScreenshotJob : public RemoteCommandJob,

void TerminateImpl() override;

void StoreScreenshot(size_t screen,

- scoped_refptr<base::RefCountedBytes> png_data);

+ scoped_refptr<base::RefCountedMemory> png_data);

void StartScreenshotUpload();

@@ -128,7 +128,7 @@ class DeviceCommandScreenshotJob : public RemoteCommandJob,

int num_pending_screenshots_;

// Caches the already completed screenshots for the different displays.

- std::map<int, scoped_refptr<base::RefCountedBytes>> screenshots_;

+ std::map<int, scoped_refptr<base::RefCountedMemory>> screenshots_;

// The Delegate is used to acquire screenshots and create UploadJobs.

std::unique_ptr<Delegate> screenshot_delegate_;