chrome/browser/chromeos/policy/remote_commands/device_command_screenshot_job_unittest.cc - Issue 2592983002: [devtools] Support different encodings for Page.CaptureScreenshot.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/policy/remote_commands/device_command_screenshot_job_unittest.cc

Issue 2592983002: [devtools] Support different encodings for Page.CaptureScreenshot. (Closed)

Patch Set: Encode in ui snapshot methods instead. Created 3 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/policy/remote_commands/device_command_screenshot_job.cc ('k') | chrome/browser/chromeos/policy/remote_commands/screenshot_delegate.h » ('j') | content/browser/devtools/protocol/devtools_protocol_browsertest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/policy/remote_commands/device_command_screenshot_job_unittest.cc

diff --git a/chrome/browser/chromeos/policy/remote_commands/device_command_screenshot_job_unittest.cc b/chrome/browser/chromeos/policy/remote_commands/device_command_screenshot_job_unittest.cc

index 5775b3694c0ef83aaaad3becacfbf16cad69feb6..cf767dadfcbc0bd480d86ea947a5a377a42363b4 100644

--- a/chrome/browser/chromeos/policy/remote_commands/device_command_screenshot_job_unittest.cc

+++ b/chrome/browser/chromeos/policy/remote_commands/device_command_screenshot_job_unittest.cc

@@ -148,7 +148,7 @@ class MockScreenshotDelegate : public DeviceCommandScreenshotJob::Delegate {

void TakeSnapshot(

gfx::NativeWindow window,

const gfx::Rect& source_rect,

- const ui::GrabWindowSnapshotAsyncPNGCallback& callback) override;

+ const ui::GrabWindowSnapshotAsyncEncodedCallback& callback) override;

std::unique_ptr<UploadJob> CreateUploadJob(const GURL&,

UploadJob::Delegate*) override;

@@ -173,7 +173,7 @@ bool MockScreenshotDelegate::IsScreenshotAllowed() {

void MockScreenshotDelegate::TakeSnapshot(

gfx::NativeWindow window,

const gfx::Rect& source_rect,

- const ui::GrabWindowSnapshotAsyncPNGCallback& callback) {

+ const ui::GrabWindowSnapshotAsyncEncodedCallback& callback) {

const int width = source_rect.width();

const int height = source_rect.height();

scoped_refptr<base::RefCountedBytes> test_png =