chrome/browser/chromeos/policy/remote_commands/device_command_screenshot_job.cc - Issue 2592983002: [devtools] Support different encodings for Page.CaptureScreenshot.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/policy/remote_commands/device_command_screenshot_job.cc

Issue 2592983002: [devtools] Support different encodings for Page.CaptureScreenshot. (Closed)

Patch Set: Encode in ui snapshot methods instead. Created 3 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/policy/remote_commands/device_command_screenshot_job.h ('k') | chrome/browser/chromeos/policy/remote_commands/device_command_screenshot_job_unittest.cc » ('j') | content/browser/devtools/protocol/devtools_protocol_browsertest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/policy/remote_commands/device_command_screenshot_job.cc

diff --git a/chrome/browser/chromeos/policy/remote_commands/device_command_screenshot_job.cc b/chrome/browser/chromeos/policy/remote_commands/device_command_screenshot_job.cc

index 2e0e156f143bef0fa6aabdcfe0ed8eeb7464c054..f092b78a9e04ad62d817886357db5733c85f0ee9 100644

--- a/chrome/browser/chromeos/policy/remote_commands/device_command_screenshot_job.cc

+++ b/chrome/browser/chromeos/policy/remote_commands/device_command_screenshot_job.cc

@@ -58,7 +58,7 @@ const char* const kUploadUrlFieldName = "fileUploadUrl";

// A helper function which invokes |store_screenshot_callback| on |task_runner|.

void RunStoreScreenshotOnTaskRunner(

- const ui::GrabWindowSnapshotAsyncPNGCallback& store_screenshot_callback,

+ const ui::GrabWindowSnapshotAsyncEncodedCallback& store_screenshot_callback,

scoped_refptr<base::TaskRunner> task_runner,

scoped_refptr<base::RefCountedBytes> png_data) {

task_runner->PostTask(FROM_HERE,