Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 2592973002: innerText, outerText should dispatch custom element reactions. (Closed)

Created:
4 years ago by dominicc (has gone to gerrit)
Modified:
3 years, 12 months ago
Reviewers:
tkent
CC:
blink-reviews, blink-reviews-html_chromium.org, blink-reviews-w3ctests_chromium.org, chromium-reviews, dglazkov+blink, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

innerText, outerText should dispatch custom element reactions. innerText in the HTML spec is specified to do CEReactions. outerText isn't in any spec, but since Blink implements something we may as well do in interoperably with WebKit. These missing CEReactions were causing us to fail a couple of tests in web-platform-tests' custom-elements/reactions/HTMLElement.html . BUG=676255 Committed: https://crrev.com/47684d7e2323e73654f8f88090a399a4705dfc00 Cr-Commit-Position: refs/heads/master@{#440330}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M third_party/WebKit/LayoutTests/imported/wpt/custom-elements/reactions/HTMLElement-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLElement.idl View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
dominicc (has gone to gerrit)
PTAL
4 years ago (2016-12-21 08:25:51 UTC) #4
tkent
lgtm
4 years ago (2016-12-21 08:28:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2592973002/1
3 years, 12 months ago (2016-12-22 03:44:04 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 12 months ago (2016-12-22 03:49:02 UTC) #12
commit-bot: I haz the power
3 years, 12 months ago (2016-12-22 03:51:25 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/47684d7e2323e73654f8f88090a399a4705dfc00
Cr-Commit-Position: refs/heads/master@{#440330}

Powered by Google App Engine
This is Rietveld 408576698