Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 2592953004: Replace DOMWindowProperty in core/timing/ with ContextClient (Closed)

Created:
4 years ago by haraken
Modified:
4 years ago
Reviewers:
sof
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace DOMWindowProperty in core/timing/ with ContextClient This is a preparation for deprecating DOMWindowProperty. BUG=610176 Committed: https://crrev.com/b7ae6e72b07e094e34ae0d82530f44c113b8f338 Cr-Commit-Position: refs/heads/master@{#440081}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -12 lines) Patch
M third_party/WebKit/Source/core/timing/DOMWindowPerformance.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/timing/DOMWindowPerformance.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/timing/PerformanceNavigation.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/timing/PerformanceNavigation.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/timing/PerformanceTiming.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/timing/PerformanceTiming.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
haraken
PTAL
4 years ago (2016-12-21 09:40:56 UTC) #2
sof
lgtm
4 years ago (2016-12-21 09:46:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2592953004/1
4 years ago (2016-12-21 11:52:13 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-21 13:22:52 UTC) #8
commit-bot: I haz the power
4 years ago (2016-12-21 13:24:48 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b7ae6e72b07e094e34ae0d82530f44c113b8f338
Cr-Commit-Position: refs/heads/master@{#440081}

Powered by Google App Engine
This is Rietveld 408576698