Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(609)

Issue 2592953003: Revert of [refactor] - Move textInputInfo() and textInputType() from WebWidget to WebInputMethodController (Closed)

Created:
4 years ago by shimazu
Modified:
4 years ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, mlamouri+watch-blink_chromium.org, nasko+codewatch_chromium.org, jam, dcheng, dglazkov+blink, darin-cc_chromium.org, blink-reviews, kinuko+watch, blink-reviews-api_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [refactor] - Move textInputInfo() and textInputType() from WebWidget to WebInputMethodController (patchset #10 id:180001 of https://codereview.chromium.org/2508363003/ ) Reason for revert: WebViewFocusInteractiveTest.Focus_FocusRestored got flaky: https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%281%29/builds/61498 Original issue's description: > [refactor] - Move textInputInfo() and textInputType() from WebWidget to WebInputMethodController > > In line with refactoring the duplicated IME code, the implementation of > WebWidget::textInputInfo() and WebWidget::textInputType() have been > moved to WebINputMethodController. The benefits of this refactor are: > > 1- This is compliant by the fact that the actual logic lives in > InputMethodController class. Therefore, it makes sense to have the > calles use the public wrapper instead of WebWidget. > > 2- This helps with the separation of WebView and WebWidget as the > refactored methods are removed from both. > > This CL follows up on the original refactoring CL which landed > WebInputMethodController (https://codereview.chromium.org/2333813002/). > > Doc: > https://docs.google.com/document/d/13Nidlg5yIsxQRqXgBPqmb-KcT8q85Z1ds9Z1-Vo1XQQ/edit?usp=sharing > > BUG=629721 > > Committed: https://crrev.com/59cd849d12cffcc4f31281e758deb18111717796 > Cr-Commit-Position: refs/heads/master@{#440046} TBR=dcheng@chromium.org,dglazkov@chromium.org,dtapuska@chromium.org,lfg@chromium.org,creis@chromium.org,ekaramad@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=629721 Committed: https://crrev.com/d2d9be2c99afab15fbd262945400cc1d9c5945c9 Cr-Commit-Position: refs/heads/master@{#440054}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+157 lines, -159 lines) Patch
M content/renderer/render_frame_impl.cc View 3 chunks +2 lines, -5 lines 0 comments Download
M content/renderer/render_view_browsertest.cc View 4 chunks +9 lines, -16 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 chunk +1 line, -4 lines 0 comments Download
M content/renderer/render_widget.cc View 3 chunks +5 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/web/WebFrameWidgetImpl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp View 1 chunk +14 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebInputMethodControllerImpl.h View 1 chunk +7 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebInputMethodControllerImpl.cpp View 1 chunk +0 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/web/WebLocalFrameImpl.h View 3 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebLocalFrameImpl.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebViewFrameWidget.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebViewFrameWidget.cpp View 1 chunk +8 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.cpp View 1 chunk +14 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/tests/WebViewTest.cpp View 57 chunks +76 lines, -99 lines 0 comments Download
M third_party/WebKit/public/web/WebInputMethodController.h View 2 chunks +2 lines, -13 lines 0 comments Download
M third_party/WebKit/public/web/WebLocalFrame.h View 2 chunks +0 lines, -4 lines 0 comments Download
M third_party/WebKit/public/web/WebView.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/public/web/WebWidget.h View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (3 generated)
shimazu
4 years ago (2016-12-21 08:38:56 UTC) #2
Created Revert of [refactor] - Move textInputInfo() and textInputType() from
WebWidget to WebInputMethodController

Powered by Google App Engine
This is Rietveld 408576698