DescriptionRevert of [refactor] - Move textInputInfo() and textInputType() from WebWidget to WebInputMethodController (patchset #10 id:180001 of https://codereview.chromium.org/2508363003/ )
Reason for revert:
WebViewFocusInteractiveTest.Focus_FocusRestored got flaky:
https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%281%29/builds/61498
Original issue's description:
> [refactor] - Move textInputInfo() and textInputType() from WebWidget to WebInputMethodController
>
> In line with refactoring the duplicated IME code, the implementation of
> WebWidget::textInputInfo() and WebWidget::textInputType() have been
> moved to WebINputMethodController. The benefits of this refactor are:
>
> 1- This is compliant by the fact that the actual logic lives in
> InputMethodController class. Therefore, it makes sense to have the
> calles use the public wrapper instead of WebWidget.
>
> 2- This helps with the separation of WebView and WebWidget as the
> refactored methods are removed from both.
>
> This CL follows up on the original refactoring CL which landed
> WebInputMethodController (https://codereview.chromium.org/2333813002/).
>
> Doc:
> https://docs.google.com/document/d/13Nidlg5yIsxQRqXgBPqmb-KcT8q85Z1ds9Z1-Vo1XQQ/edit?usp=sharing
>
> BUG=629721
>
> Committed: https://crrev.com/59cd849d12cffcc4f31281e758deb18111717796
> Cr-Commit-Position: refs/heads/master@{#440046}
TBR=dcheng@chromium.org,dglazkov@chromium.org,dtapuska@chromium.org,lfg@chromium.org,creis@chromium.org,ekaramad@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=629721
Committed: https://crrev.com/d2d9be2c99afab15fbd262945400cc1d9c5945c9
Cr-Commit-Position: refs/heads/master@{#440054}
Patch Set 1 #Messages
Total messages: 4 (3 generated)
|