Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2592883003:
base: Extend cgroup adjustments to both cpuset and schedtune. (Closed)
Descriptionbase: Extend cgroup adjustments to both cpuset and schedtune.
Make the same cgroup adjustments based on thread priority
for schedtune as for cpuset on Linux.
BUG=chrome-os-partner:56550
TEST=
Committed: https://crrev.com/227e8c0725a73c5f93b6c7f23e3d5563e4f13431
Cr-Commit-Position: refs/heads/master@{#440169}
Patch Set 1 #Patch Set 2 : remove non-"chrome" suffix fallback #Messages
Total messages: 20 (12 generated)
The CQ bit was checked by reveman@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
sonnyrao@chromium.org changed reviewers: + sonnyrao@chromium.org
+1 I verified this is working
reveman@chromium.org changed reviewers: + thakis@chromium.org
+thakis
lgtm
Description was changed from ========== base: Extend cgroup adjustments to both cpuset and schedtune. Make the same cgroup adjustments based on thread priority for schedtune as for cpuset on Linux. Try the "chrome" suffix as before but also fallback to non-"chrome" suffix path. The suffix is preferred but doesn't exist for schedtune yet. BUG=chrome-os-partner:56550 TEST= ========== to ========== base: Extend cgroup adjustments to both cpuset and schedtune. Make the same cgroup adjustments based on thread priority for schedtune as for cpuset on Linux. BUG=chrome-os-partner:56550 TEST= ==========
The CQ bit was checked by reveman@chromium.org
Latest patch just removed the non-"chrome" prefix fallback as we've managed to get that prefix working for schedtune as well now.
The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org Link to the patchset: https://codereview.chromium.org/2592883003/#ps20001 (title: "remove non-"chrome" suffix fallback")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1482343278271060,
"parent_rev": "c563d3cbf3edb29852331b1b0b01b2f228e43f2e", "commit_rev":
"caa3da598ee9fb59c4f9462f46dccbfd1dece94a"}
Message was sent while issue was closed.
Description was changed from ========== base: Extend cgroup adjustments to both cpuset and schedtune. Make the same cgroup adjustments based on thread priority for schedtune as for cpuset on Linux. BUG=chrome-os-partner:56550 TEST= ========== to ========== base: Extend cgroup adjustments to both cpuset and schedtune. Make the same cgroup adjustments based on thread priority for schedtune as for cpuset on Linux. BUG=chrome-os-partner:56550 TEST= Review-Url: https://codereview.chromium.org/2592883003 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== base: Extend cgroup adjustments to both cpuset and schedtune. Make the same cgroup adjustments based on thread priority for schedtune as for cpuset on Linux. BUG=chrome-os-partner:56550 TEST= Review-Url: https://codereview.chromium.org/2592883003 ========== to ========== base: Extend cgroup adjustments to both cpuset and schedtune. Make the same cgroup adjustments based on thread priority for schedtune as for cpuset on Linux. BUG=chrome-os-partner:56550 TEST= Committed: https://crrev.com/227e8c0725a73c5f93b6c7f23e3d5563e4f13431 Cr-Commit-Position: refs/heads/master@{#440169} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/227e8c0725a73c5f93b6c7f23e3d5563e4f13431 Cr-Commit-Position: refs/heads/master@{#440169} |
