Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2592873002:
Roll clang 289944:289944. (Closed)
|
Created:
4 years ago by dcheng Modified:
4 years ago Reviewers:
Nico CC:
chromium-reviews, eugenis+clang_chromium.org, vmpstr+watch_chromium.org, Lei Zhang, dsinclair, yunlian, glider+clang_chromium.org, ukai+watch_chromium.org, Reid Kleckner, hans, dmikurube+clang_chromium.org, nasko, Łukasz Anforowicz Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRoll clang 289944:289944.
Ran `tools/clang/scripts/upload_revision.py 289944 2`
with the following fixes in the blink_gc_plugin:
1fb76ab Disallow heap objects containing unsafe on-heap iterators
2de974b Add use-chromium-style-naming option to Blink GC plugin.
BUG=584538
Committed: https://crrev.com/2a55cfede1ba52fb308234eeeedda0ead1772d7a
Cr-Commit-Position: refs/heads/master@{#440364}
Patch Set 1 #
Messages
Total messages: 27 (19 generated)
Description was changed from ========== Roll clang 289944:289944. Ran `tools/clang/scripts/upload_revision.py 289944 2`. ========== to ========== Roll clang 289944:289944. Ran `tools/clang/scripts/upload_revision.py 289944 2`. BUG=584538 ==========
dcheng@chromium.org changed reviewers: + thakis@chromium.org
Looks like the try jobs are done, so the binaries just need to be pushed per https://codereview.chromium.org/2578103003/#msg15
The CQ bit was checked by dcheng@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_clang on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)
The CQ bit was checked by dcheng@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_clang on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)
The CQ bit was checked by dcheng@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Looks like the bots are happy now.
lgtm
On 2016/12/22 05:14:48, Nico (swamped sorry) wrote: > lgtm (Maybe expand cl description)
Description was changed from ========== Roll clang 289944:289944. Ran `tools/clang/scripts/upload_revision.py 289944 2`. BUG=584538 ========== to ========== Roll clang 289944:289944. Ran `tools/clang/scripts/upload_revision.py 289944 2` with the following fixes in the blink_gc_plugin: 1fb76ab Disallow heap objects containing unsafe on-heap iterators 2de974b Add use-chromium-style-naming option to Blink GC plugin. BUG=584538 ==========
On 2016/12/22 05:15:32, Nico (swamped sorry) wrote: > On 2016/12/22 05:14:48, Nico (swamped sorry) wrote: > > lgtm > > (Maybe expand cl description) Updated it to note which two plugin CLs are getting picked up by this (I think).
The CQ bit was checked by dcheng@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1482389241033570, "parent_rev":
"c99e1d08bf7993c8c826c53474fb6c2df57c4d42", "commit_rev":
"1046f70e61cf637f7788700b552b0f58f519af73"}
Message was sent while issue was closed.
Description was changed from ========== Roll clang 289944:289944. Ran `tools/clang/scripts/upload_revision.py 289944 2` with the following fixes in the blink_gc_plugin: 1fb76ab Disallow heap objects containing unsafe on-heap iterators 2de974b Add use-chromium-style-naming option to Blink GC plugin. BUG=584538 ========== to ========== Roll clang 289944:289944. Ran `tools/clang/scripts/upload_revision.py 289944 2` with the following fixes in the blink_gc_plugin: 1fb76ab Disallow heap objects containing unsafe on-heap iterators 2de974b Add use-chromium-style-naming option to Blink GC plugin. BUG=584538 Review-Url: https://codereview.chromium.org/2592873002 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Roll clang 289944:289944. Ran `tools/clang/scripts/upload_revision.py 289944 2` with the following fixes in the blink_gc_plugin: 1fb76ab Disallow heap objects containing unsafe on-heap iterators 2de974b Add use-chromium-style-naming option to Blink GC plugin. BUG=584538 Review-Url: https://codereview.chromium.org/2592873002 ========== to ========== Roll clang 289944:289944. Ran `tools/clang/scripts/upload_revision.py 289944 2` with the following fixes in the blink_gc_plugin: 1fb76ab Disallow heap objects containing unsafe on-heap iterators 2de974b Add use-chromium-style-naming option to Blink GC plugin. BUG=584538 Committed: https://crrev.com/2a55cfede1ba52fb308234eeeedda0ead1772d7a Cr-Commit-Position: refs/heads/master@{#440364} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/2a55cfede1ba52fb308234eeeedda0ead1772d7a Cr-Commit-Position: refs/heads/master@{#440364} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
