Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(693)

Issue 2592823003: Replace the remaining DOMWindowProperty with ContextClient (Closed)

Created:
4 years ago by haraken
Modified:
4 years ago
Reviewers:
sof
CC:
chromium-reviews, mlamouri+watch-blink_chromium.org, blink-reviews, haraken, kinuko+watch, mlamouri+watch-screen-orientation_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace the remaining DOMWindowProperty with ContextClient This is the final CL to replace DOMWindowProperty with ContextClient. We can remove DOMWindowProperty in the next CL. BUG=610176 Committed: https://crrev.com/725822fe81ac2b4d89ae438fb4d975184478c889 Cr-Commit-Position: refs/heads/master@{#440089}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -16 lines) Patch
M third_party/WebKit/Source/modules/screen_orientation/ScreenOrientation.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/screen_orientation/ScreenOrientation.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/storage/Storage.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/storage/Storage.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebPluginContainerImpl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebPluginContainerImpl.cpp View 2 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
haraken
PTAL I think this is the final one.
4 years ago (2016-12-21 12:24:59 UTC) #2
sof
lgtm
4 years ago (2016-12-21 12:32:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2592823003/1
4 years ago (2016-12-21 12:36:11 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-21 14:19:54 UTC) #8
commit-bot: I haz the power
4 years ago (2016-12-21 14:23:49 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/725822fe81ac2b4d89ae438fb4d975184478c889
Cr-Commit-Position: refs/heads/master@{#440089}

Powered by Google App Engine
This is Rietveld 408576698