Dump MappedMemoryManager memory via GLES2Implementation

Dump MappedMemoryManager memory via GLES2Implementation

Due to threading issues, we'd already changed several components
of the GL command buffer to dump their memory heirarchically through
a single registration point in ContextProviderCommandBuffer.

MappedMemoryManager was missed. Modifying it so it doesn't register
to dump directly, but is dumped through ContextProviderCommandBuffer >
GLES2Implementation > MappedMemoryManager.

R=ssid
BUG=675821
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/4f2afdb2933744b91906b3b881aaeaf9b9523deb
Cr-Commit-Position: refs/heads/master@{#440884}

[ericrk, 2016-12-20 19:57:38]

Description was changed from

==========
Dump MappedMemoryManager memory via GLES2Implementation

Due to threading issues, we'd already changed several components
of the GL command buffer to dump their memory heirarchically through
a single registration point in ContextProviderCommandBuffer.

MappedMemoryManager was missed. Modifying it so it doesn't register
to dump directly, but is dumped through ContextProviderCommandBuffer >
GLES2Implementation > MappedMemoryManager.

R=ssid
BUG=675821
==========

to

==========
Dump MappedMemoryManager memory via GLES2Implementation

Due to threading issues, we'd already changed several components
of the GL command buffer to dump their memory heirarchically through
a single registration point in ContextProviderCommandBuffer.

MappedMemoryManager was missed. Modifying it so it doesn't register
to dump directly, but is dumped through ContextProviderCommandBuffer >
GLES2Implementation > MappedMemoryManager.

R=ssid
BUG=675821
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[ericrk, 2016-12-20 19:58:10]

The CQ bit was checked by ericrk@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-20 19:58:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-20 20:11:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-20 20:11:18]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[ssid, 2016-12-20 21:45:55]

thanks! lgtm

[ericrk, 2016-12-20 21:59:30]

ericrk@chromium.org changed reviewers:
+ jbauman@chromium.org

[jbauman, 2016-12-20 22:01:56]

lgtm (with compile fix)

[ericrk, 2016-12-21 19:24:37]

fix build

[ericrk, 2016-12-21 19:25:58]

The CQ bit was checked by ericrk@chromium.org

[ericrk, 2016-12-21 19:25:59]

The patchset sent to the CQ was uploaded after l-g-t-m from ssid@chromium.org,
jbauman@chromium.org
Link to the patchset: https://codereview.chromium.org/2592803002/#ps20001
(title: "fix build")

[commit-bot: I haz the power, 2016-12-21 19:26:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-21 20:48:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-21 20:48:22]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[ericrk, 2016-12-28 19:03:44]

The CQ bit was checked by ericrk@chromium.org

[commit-bot: I haz the power, 2016-12-28 19:03:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-28 20:10:24]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1482951824095020,
"parent_rev": "5c0468fc843a7b9cfcfd65160ce195ab843876d6", "commit_rev":
"db91936db64e83858b6b895c0b5cc8a7a770db08"}

[commit-bot: I haz the power, 2016-12-28 20:10:48]

Description was changed from

==========
Dump MappedMemoryManager memory via GLES2Implementation

Due to threading issues, we'd already changed several components
of the GL command buffer to dump their memory heirarchically through
a single registration point in ContextProviderCommandBuffer.

MappedMemoryManager was missed. Modifying it so it doesn't register
to dump directly, but is dumped through ContextProviderCommandBuffer >
GLES2Implementation > MappedMemoryManager.

R=ssid
BUG=675821
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Dump MappedMemoryManager memory via GLES2Implementation

Due to threading issues, we'd already changed several components
of the GL command buffer to dump their memory heirarchically through
a single registration point in ContextProviderCommandBuffer.

MappedMemoryManager was missed. Modifying it so it doesn't register
to dump directly, but is dumped through ContextProviderCommandBuffer >
GLES2Implementation > MappedMemoryManager.

R=ssid
BUG=675821
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2592803002
==========

[commit-bot: I haz the power, 2016-12-28 20:10:50]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2017-01-02 15:50:02]

Description was changed from

==========
Dump MappedMemoryManager memory via GLES2Implementation

Due to threading issues, we'd already changed several components
of the GL command buffer to dump their memory heirarchically through
a single registration point in ContextProviderCommandBuffer.

MappedMemoryManager was missed. Modifying it so it doesn't register
to dump directly, but is dumped through ContextProviderCommandBuffer >
GLES2Implementation > MappedMemoryManager.

R=ssid
BUG=675821
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2592803002
==========

to

==========
Dump MappedMemoryManager memory via GLES2Implementation

Due to threading issues, we'd already changed several components
of the GL command buffer to dump their memory heirarchically through
a single registration point in ContextProviderCommandBuffer.

MappedMemoryManager was missed. Modifying it so it doesn't register
to dump directly, but is dumped through ContextProviderCommandBuffer >
GLES2Implementation > MappedMemoryManager.

R=ssid
BUG=675821
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/4f2afdb2933744b91906b3b881aaeaf9b9523deb
Cr-Commit-Position: refs/heads/master@{#440884}
==========

[commit-bot: I haz the power, 2017-01-02 15:50:02]

Patchset 2 (id:??) landed as
https://crrev.com/4f2afdb2933744b91906b3b881aaeaf9b9523deb
Cr-Commit-Position: refs/heads/master@{#440884}