Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(438)

Unified Diff: storage/browser/quota/quota_settings.cc

Issue 2592793002: Revert of Change how the quota system computes the total poolsize for temporary storage (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « storage/browser/quota/quota_settings.h ('k') | storage/browser/quota/quota_temporary_storage_evictor.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: storage/browser/quota/quota_settings.cc
diff --git a/storage/browser/quota/quota_settings.cc b/storage/browser/quota/quota_settings.cc
deleted file mode 100644
index 2b737098de777194d2f887e84e7dba8850ce5af7..0000000000000000000000000000000000000000
--- a/storage/browser/quota/quota_settings.cc
+++ /dev/null
@@ -1,83 +0,0 @@
-// Copyright 2016 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "storage/browser/quota/quota_settings.h"
-
-#include <algorithm>
-
-#include "base/metrics/histogram_macros.h"
-#include "base/sys_info.h"
-
-#define UMA_HISTOGRAM_MBYTES(name, sample) \
- UMA_HISTOGRAM_CUSTOM_COUNTS((name), static_cast<int>((sample) / kMBytes), 1, \
- 10 * 1024 * 1024 /* 10TB */, 100)
-
-namespace storage {
-
-base::Optional<storage::QuotaSettings> CalculateNominalDynamicSettings(
- const base::FilePath& partition_path,
- bool is_incognito) {
- const int64_t kMBytes = 1024 * 1024;
-
- if (is_incognito) {
- storage::QuotaSettings settings;
- settings.pool_size =
- std::min(300 * kMBytes, base::SysInfo::AmountOfPhysicalMemory() / 10);
- settings.per_host_quota = settings.pool_size / 3;
- settings.refresh_interval = base::TimeDelta::Max();
- return settings;
- }
-
- // The fraction of the device's storage the browser is willing to
- // use for temporary storage, this is applied after adjusting the
- // total to take os_accomodation into account.
- const double kTemporaryPoolSizeRatio = 1.0 / 3.0; // 33%
-
- // The fraction of the device's storage the browser attempts to
- // keep free.
- const double kMustRemainAvailableRatio = 0.1;
-
- // Determines the portion of the temp pool that can be
- // utilized by a single host (ie. 5 for 20%).
- const int kPerHostTemporaryPortion = 5;
-
- // os_accomodation is an estimate of how much storage is needed for
- // the os and essential application code outside of the browser.
- const int64_t kDefaultOSAccomodation =
-#if defined(OS_ANDROID)
- 1000 * kMBytes;
-#elif defined(OS_CHROMEOS)
- 1000 * kMBytes;
-#elif defined(OS_WIN) || defined(OS_LINUX) || defined(OS_MACOSX)
- 10000 * kMBytes;
-#else
-#error "Port: Need to define an OS accomodation value for unknown OS."
-#endif
-
- storage::QuotaSettings settings;
-
- int64_t total = base::SysInfo::AmountOfTotalDiskSpace(partition_path);
- if (total == -1) {
- LOG(ERROR) << "Unable to compute QuotaSettings.";
- return base::nullopt;
- }
-
- // If our hardcoded OS accomodation is too large for the volume size, define
- // the value as a fraction of the total volume size instead.
- int64_t os_accomodation =
- std::min(kDefaultOSAccomodation, static_cast<int64_t>(total * 0.8));
- UMA_HISTOGRAM_MBYTES("Quota.OSAccomodationDelta",
- kDefaultOSAccomodation - os_accomodation);
-
- int64_t adjusted_total = total - os_accomodation;
- int64_t pool_size = adjusted_total * kTemporaryPoolSizeRatio;
-
- settings.pool_size = pool_size;
- settings.must_remain_available = total * kMustRemainAvailableRatio;
- settings.per_host_quota = pool_size / kPerHostTemporaryPortion;
- settings.refresh_interval = base::TimeDelta::FromSeconds(60);
- return settings;
-}
-
-} // namespace
« no previous file with comments | « storage/browser/quota/quota_settings.h ('k') | storage/browser/quota/quota_temporary_storage_evictor.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698