Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(1)

Issue 2592793002: Revert of Change how the quota system computes the total poolsize for temporary storage (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 months, 1 week ago by jsbell
Modified:
5 months, 1 week ago
Reviewers:
kinuko, jam
CC:
chromium-reviews, msramek+watch_chromium.org, sadrul, vmpstr+watch_chromium.org, dominickn+watch_chromium.org, chasej+watch_chromium.org, nyquist+watch-blimp_chromium.org, iclelland+watch_chromium.org, kmarshall+watch-blimp_chromium.org, markusheintz_, shaktisahu+watch-blimp_chromium.org, extensions-reviews_chromium.org, wjmaclean, maniscalco+watch-blimp_chromium.org, bgoldman+watch-blimp_chromium.org, lcwu+watch_chromium.org, tzik, jam, gcasto+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, darin-cc_chromium.org, jkarlin+watch_chromium.org, lethalantidote+watch-blimp_chromium.org, kalyank, scf+watch-blimp_chromium.org, mlamouri+watch-content_chromium.org, halliwell+watch_chromium.org, Peter Beverloo, nhiroki (slow), jochen+watch_chromium.org, asvitkine+watch_chromium.org, chromium-apps-reviews_chromium.org, alokp+watch_chromium.org, jsbell+idb_chromium.org, khushalsagar+watch-blimp_chromium.org, mlamouri+watch-test-runner_chromium.org, michaeln, anandc+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org, steimel+watch-blimp_chromium.org, android-webview-reviews_chromium.org, perumaal+watch-blimp_chromium.org, cmumford, dtrainor+watch-blimp_chromium.org, kinuko+fileapi, einbinder+watch-test-runner_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Change how the quota system computes the total poolsize for temporary storage Seems to have negatively impacted quota allocation. Original CL: https://codereview.chromium.org/1782053004/ Original Committed: https://crrev.com/db78e67f2c47c3b2e7bd548d9d1a4e4f1b3124e4 Original Cr-Commit-Position: refs/heads/master@{#438741} BUG=520318, 675875 R=cmumford@chromium.org TBR=isherman@chromium.org Committed: https://crrev.com/26ccaa7865154cadca323a7d38ea2482a42f654b Cr-Commit-Position: refs/heads/master@{#440079}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1792 lines, -1302 lines) Patch
M android_webview/browser/DEPS View 1 chunk +0 lines, -2 lines 0 comments Download
M android_webview/browser/aw_content_browser_client.h View 1 chunk +0 lines, -4 lines 0 comments Download
M android_webview/browser/aw_content_browser_client.cc View 3 chunks +0 lines, -13 lines 0 comments Download
M ash/shell/content/client/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M ash/shell/content/client/shell_content_browser_client.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ash/shell/content/client/shell_content_browser_client.cc View 2 chunks +0 lines, -15 lines 0 comments Download
M base/time/time.h View 2 chunks +1 line, -6 lines 0 comments Download
M base/time/time.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M blimp/engine/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M blimp/engine/app/blimp_content_browser_client.h View 1 chunk +0 lines, -4 lines 0 comments Download
M blimp/engine/app/blimp_content_browser_client.cc View 2 chunks +0 lines, -14 lines 0 comments Download
M chrome/browser/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/browsing_data/browsing_data_quota_helper_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.h View 3 chunks +2 lines, -11 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 4 chunks +7 lines, -22 lines 0 comments Download
A chrome/browser/engagement/site_engagement_eviction_policy.h View 1 chunk +56 lines, -0 lines 0 comments Download
A chrome/browser/engagement/site_engagement_eviction_policy.cc View 1 chunk +144 lines, -0 lines 0 comments Download
A chrome/browser/engagement/site_engagement_eviction_policy_unittest.cc View 1 chunk +173 lines, -0 lines 0 comments Download
M chrome/browser/engagement/site_engagement_service.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc View 3 chunks +16 lines, -10 lines 0 comments Download
M chrome/browser/extensions/api/sync_file_system/sync_file_system_apitest.cc View 4 chunks +8 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/sync_file_system/sync_file_system_browsertest.cc View 3 chunks +15 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_special_storage_policy.h View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_special_storage_policy.cc View 4 chunks +12 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_special_storage_policy_unittest.cc View 1 chunk +17 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_storage_monitor.cc View 2 chunks +13 lines, -9 lines 0 comments Download
M chrome/browser/extensions/mock_extension_special_storage_policy.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/mock_extension_special_storage_policy.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/sync_file_system/local/canned_syncable_file_system.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/webui/quota_internals/quota_internals_proxy.h View 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/quota_internals/quota_internals_proxy.cc View 2 chunks +26 lines, -14 lines 0 comments Download
M chrome/test/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/DEPS View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/test/base/in_process_browser_test.h View 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/test/base/in_process_browser_test.cc View 3 chunks +0 lines, -8 lines 0 comments Download
M chromecast/browser/cast_content_browser_client.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chromecast/browser/cast_content_browser_client.cc View 2 chunks +0 lines, -11 lines 0 comments Download
M content/browser/appcache/appcache_host_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/appcache/appcache_storage_impl_unittest.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M content/browser/background_sync/background_sync_manager_unittest.cc View 1 chunk +3 lines, -1 line 0 comments Download
M content/browser/background_sync/background_sync_service_impl_unittest.cc View 1 chunk +3 lines, -1 line 0 comments Download
M content/browser/browsing_data/clear_site_data_throttle_browsertest.cc View 2 chunks +0 lines, -8 lines 0 comments Download
M content/browser/database_tracker_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/fileapi/file_system_browsertest.cc View 1 chunk +15 lines, -13 lines 0 comments Download
M content/browser/fileapi/obfuscated_file_util_unittest.cc View 1 chunk +1 line, -8 lines 0 comments Download
M content/browser/indexed_db/indexed_db_browsertest.cc View 1 chunk +15 lines, -13 lines 0 comments Download
M content/browser/payments/payment_app_content_unittest_base.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M content/browser/quota/mock_quota_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/quota/mock_quota_manager.cc View 1 chunk +7 lines, -6 lines 0 comments Download
M content/browser/quota/mock_quota_manager_proxy.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/quota/mock_quota_manager_proxy.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/quota/quota_backend_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/quota/quota_manager_unittest.cc View 27 chunks +177 lines, -121 lines 0 comments Download
M content/browser/quota/quota_temporary_storage_evictor_unittest.cc View 14 chunks +72 lines, -53 lines 0 comments Download
M content/browser/quota/storage_monitor_unittest.cc View 4 chunks +4 lines, -6 lines 0 comments Download
M content/browser/storage_partition_impl.h View 4 chunks +17 lines, -10 lines 0 comments Download
M content/browser/storage_partition_impl.cc View 5 chunks +94 lines, -58 lines 0 comments Download
M content/browser/storage_partition_impl_map.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M content/public/browser/BUILD.gn View 2 chunks +1 line, -3 lines 0 comments Download
M content/public/browser/content_browser_client.h View 4 chunks +5 lines, -9 lines 0 comments Download
M content/public/browser/content_browser_client.cc View 2 chunks +4 lines, -7 lines 0 comments Download
M content/public/test/mock_special_storage_policy.h View 4 chunks +7 lines, -0 lines 0 comments Download
M content/public/test/mock_special_storage_policy.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M content/shell/browser/layout_test/layout_test_browser_main_parts.cc View 3 chunks +20 lines, -0 lines 0 comments Download
M content/shell/browser/layout_test/layout_test_content_browser_client.h View 1 chunk +0 lines, -4 lines 0 comments Download
M content/shell/browser/layout_test/layout_test_content_browser_client.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M content/shell/browser/layout_test/layout_test_message_filter.cc View 1 chunk +3 lines, -1 line 0 comments Download
M content/shell/browser/shell_content_browser_client.h View 1 chunk +0 lines, -4 lines 0 comments Download
M content/shell/browser/shell_content_browser_client.cc View 2 chunks +0 lines, -8 lines 0 comments Download
M content/test/test_content_browser_client.h View 1 chunk +0 lines, -4 lines 0 comments Download
M content/test/test_content_browser_client.cc View 2 chunks +0 lines, -8 lines 0 comments Download
M extensions/shell/browser/shell_content_browser_client.h View 1 chunk +1 line, -4 lines 0 comments Download
M extensions/shell/browser/shell_content_browser_client.cc View 2 chunks +0 lines, -12 lines 0 comments Download
M extensions/shell/browser/shell_special_storage_policy.h View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/shell/browser/shell_special_storage_policy.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M headless/lib/browser/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M headless/lib/browser/headless_content_browser_client.h View 1 chunk +0 lines, -4 lines 0 comments Download
M headless/lib/browser/headless_content_browser_client.cc View 2 chunks +0 lines, -13 lines 0 comments Download
M storage/browser/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M storage/browser/quota/client_usage_tracker.h View 1 chunk +0 lines, -1 line 0 comments Download
M storage/browser/quota/client_usage_tracker.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M storage/browser/quota/quota_manager.h View 19 chunks +126 lines, -76 lines 0 comments Download
M storage/browser/quota/quota_manager.cc View 24 chunks +568 lines, -371 lines 0 comments Download
M storage/browser/quota/quota_manager_proxy.h View 2 chunks +7 lines, -5 lines 0 comments Download
M storage/browser/quota/quota_manager_proxy.cc View 2 chunks +2 lines, -2 lines 0 comments Download
D storage/browser/quota/quota_settings.h View 1 chunk +0 lines, -82 lines 0 comments Download
D storage/browser/quota/quota_settings.cc View 1 chunk +0 lines, -83 lines 0 comments Download
M storage/browser/quota/quota_temporary_storage_evictor.h View 3 chunks +26 lines, -8 lines 0 comments Download
M storage/browser/quota/quota_temporary_storage_evictor.cc View 8 chunks +69 lines, -45 lines 0 comments Download
M storage/browser/quota/special_storage_policy.h View 1 chunk +4 lines, -0 lines 0 comments Download
M storage/browser/quota/usage_tracker.h View 1 chunk +1 line, -2 lines 0 comments Download
M storage/browser/quota/usage_tracker.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +0 lines, -21 lines 0 comments Download
M ui/views_content_client/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M ui/views_content_client/views_content_browser_client.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/views_content_client/views_content_browser_client.cc View 2 chunks +0 lines, -15 lines 0 comments Download
Commit queue not available (can’t edit this change).

Messages

Total messages: 21 (15 generated)
jsbell
cmumford@ - can you sanity check my revert before I send this off for L*G*T*Ms ...
5 months, 1 week ago (2016-12-20 21:41:50 UTC) #5
jsbell
jam@ - can you review this revert (and CQ if LG?) (I'm OOO for two ...
5 months, 1 week ago (2016-12-20 23:39:43 UTC) #9
kinuko
lgtm
5 months, 1 week ago (2016-12-21 13:00:55 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2592793002/1
5 months, 1 week ago (2016-12-21 13:02:11 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 months, 1 week ago (2016-12-21 13:09:42 UTC) #19
commit-bot: I haz the power
5 months, 1 week ago (2016-12-21 13:11:29 UTC) #21
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/26ccaa7865154cadca323a7d38ea2482a42f654b
Cr-Commit-Position: refs/heads/master@{#440079}
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 650457f06