chrome/android/java/res/layout/payment_request_editor_dropdown.xml - Issue 2592733002: [Payments] Update billing address dropdown style to match the design

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/res/layout/payment_request_editor_dropdown.xml

Issue 2592733002: [Payments] Update billing address dropdown style to match the design (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/android/java/res/layout/payment_request_editor_dropdown.xml

diff --git a/chrome/android/java/res/layout/payment_request_editor_dropdown.xml b/chrome/android/java/res/layout/payment_request_editor_dropdown.xml

index 0464f5d025c624294d52bae3dd7011686f22e6a0..e859bb56e2a49fc5ad1f47f50713a07924ed9727 100644

--- a/chrome/android/java/res/layout/payment_request_editor_dropdown.xml

+++ b/chrome/android/java/res/layout/payment_request_editor_dropdown.xml

@@ -21,9 +21,10 @@

<android.support.v7.widget.AppCompatSpinner

android:id="@+id/spinner"

- android:layout_width="fill_parent"

+ android:layout_width="match_parent"

android:layout_height="wrap_content"

- android:layout_marginTop="@dimen/pref_autofill_field_top_margin" />

+ android:layout_marginTop="@dimen/pref_autofill_field_top_margin"

+ android:dropDownWidth="match_parent" />

Ian Wen 2016/12/20 21:52:23 Q: how does this look on tablets? On Nexus 10 will

gogerald1 2016/12/21 00:36:34 I think it's fine since the spinner width is large