Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Side by Side Diff: chrome/android/java/res/layout/payment_request_editor_dropdown.xml

Issue 2592733002: [Payments] Update billing address dropdown style to match the design (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 <?xml version="1.0" encoding="utf-8"?> 1 <?xml version="1.0" encoding="utf-8"?>
2 <!-- Copyright 2016 The Chromium Authors. All rights reserved. 2 <!-- Copyright 2016 The Chromium Authors. All rights reserved.
3 Use of this source code is governed by a BSD-style license that can be 3 Use of this source code is governed by a BSD-style license that can be
4 found in the LICENSE file. --> 4 found in the LICENSE file. -->
5 5
6 <LinearLayout 6 <LinearLayout
7 xmlns:android="http://schemas.android.com/apk/res/android" 7 xmlns:android="http://schemas.android.com/apk/res/android"
8 android:layout_width="match_parent" 8 android:layout_width="match_parent"
9 android:layout_height="wrap_content" 9 android:layout_height="wrap_content"
10 android:layout_marginTop="@dimen/payments_section_large_spacing" 10 android:layout_marginTop="@dimen/payments_section_large_spacing"
11 android:layout_marginBottom="@dimen/payments_section_large_spacing" 11 android:layout_marginBottom="@dimen/payments_section_large_spacing"
12 android:layout_marginStart="@dimen/pref_autofill_field_horizontal_paddin g" 12 android:layout_marginStart="@dimen/pref_autofill_field_horizontal_paddin g"
13 android:layout_marginEnd="@dimen/pref_autofill_field_horizontal_padding" 13 android:layout_marginEnd="@dimen/pref_autofill_field_horizontal_padding"
14 android:orientation="vertical"> 14 android:orientation="vertical">
15 15
16 <TextView 16 <TextView
17 android:id="@+id/spinner_label" 17 android:id="@+id/spinner_label"
18 android:layout_width="match_parent" 18 android:layout_width="match_parent"
19 android:layout_height="wrap_content" 19 android:layout_height="wrap_content"
20 android:textAppearance="@style/PreferenceFloatLabelTextAppearance" / > 20 android:textAppearance="@style/PreferenceFloatLabelTextAppearance" / >
21 21
22 <android.support.v7.widget.AppCompatSpinner 22 <android.support.v7.widget.AppCompatSpinner
23 android:id="@+id/spinner" 23 android:id="@+id/spinner"
24 android:layout_width="fill_parent" 24 android:layout_width="match_parent"
25 android:layout_height="wrap_content" 25 android:layout_height="wrap_content"
26 android:layout_marginTop="@dimen/pref_autofill_field_top_margin" /> 26 android:layout_marginTop="@dimen/pref_autofill_field_top_margin"
27 android:dropDownWidth="match_parent" />
Ian Wen 2016/12/20 21:52:23 Q: how does this look on tablets? On Nexus 10 will
gogerald1 2016/12/21 00:36:34 I think it's fine since the spinner width is large
27 28
28 <View style="@style/PreferenceSpinnerUnderlineView" /> 29 <View style="@style/PreferenceSpinnerUnderlineView" />
29 30
30 </LinearLayout> 31 </LinearLayout>
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698