Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(392)

Issue 2592663003: NTP: VariationParamsManager resetting works, so make it a member. (Closed)

Created:
4 years ago by fhorschig
Modified:
4 years ago
Reviewers:
jkrcal
CC:
chromium-reviews, ntp-dev+reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

NTP: VariationParamsManager resetting works, so make it a member. This CL makes use of the resetting function VariationParamsManager. This should work now and therefore it is sufficient to hold the manager as a simple member. BUG=672010 Committed: https://crrev.com/08db2becc667bf907330d414f372f4c297b8a54f Cr-Commit-Position: refs/heads/master@{#439839}

Patch Set 1 #

Patch Set 2 : Removed unused functionality of test helpers #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -35 lines) Patch
M components/ntp_snippets/remote/ntp_snippets_fetcher_unittest.cc View 1 5 chunks +15 lines, -35 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 11 (5 generated)
fhorschig
Hi Jan, this small CL is related to http://crbug.com/672010 and shows that clearing the params ...
4 years ago (2016-12-20 13:31:27 UTC) #1
jkrcal
lgtm, thanks! (By the way, you've forgotten to address me in the previous message ;)
4 years ago (2016-12-20 14:44:44 UTC) #3
fhorschig
On 2016/12/20 14:44:44, jkrcal wrote: > lgtm, thanks! > > (By the way, you've forgotten ...
4 years ago (2016-12-20 14:48:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2592663003/20001
4 years ago (2016-12-20 17:01:18 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-20 17:47:17 UTC) #9
commit-bot: I haz the power
4 years ago (2016-12-20 17:50:00 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/08db2becc667bf907330d414f372f4c297b8a54f
Cr-Commit-Position: refs/heads/master@{#439839}

Powered by Google App Engine
This is Rietveld 408576698