Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(724)

Issue 2592663002: Deflake inspector-protocol/network/resource-type.html (Closed)

Created:
4 years ago by yhirano
Modified:
4 years ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Deflake inspector-protocol/network/resource-type.html Test test reads body right after receiving a response, but it leads to some flakiness. It is not guaranteed that the response body is available at the moment. This change fixes the problem by reading response body after the loading finishes. BUG=675924 R=dgozman@chromium.org Committed: https://crrev.com/8b84279bddddb3992877fefb57d84400c087f070 Cr-Commit-Position: refs/heads/master@{#439844}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -4 lines) Patch
M third_party/WebKit/LayoutTests/inspector-protocol/network/resource-type.html View 3 chunks +17 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
yhirano
4 years ago (2016-12-20 11:57:11 UTC) #3
dgozman
lgtm
4 years ago (2016-12-20 17:32:33 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2592663002/1
4 years ago (2016-12-20 18:04:33 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-20 18:09:48 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-20 18:12:30 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8b84279bddddb3992877fefb57d84400c087f070
Cr-Commit-Position: refs/heads/master@{#439844}

Powered by Google App Engine
This is Rietveld 408576698