Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Issue 2592653005: Virtualize DataUseRecorder's destructor (Closed)

Created:
4 years ago by RyanSturm
Modified:
4 years ago
Reviewers:
sclittle
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Virtualize DataUseRecorder's destructor DataUseRecorder's destructor is not virtual and ChromeDataUseRecorder inherits from it. While there are no delete's called on DataUseRecorder pointers, this may not hold true in the future. BUG=676147 Committed: https://crrev.com/35bfb2b24de94145f1aac42a41c73e11427281d4 Cr-Commit-Position: refs/heads/master@{#439941}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/data_use_measurement/chrome_data_use_recorder.h View 1 chunk +1 line, -1 line 0 comments Download
M components/data_use_measurement/core/data_use_recorder.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (9 generated)
RyanSturm
sclittle: PTAL
4 years ago (2016-12-20 22:56:37 UTC) #4
sclittle
LGTM
4 years ago (2016-12-20 22:57:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2592653005/1
4 years ago (2016-12-20 23:53:59 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-21 00:03:49 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-21 00:05:55 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/35bfb2b24de94145f1aac42a41c73e11427281d4
Cr-Commit-Position: refs/heads/master@{#439941}

Powered by Google App Engine
This is Rietveld 408576698