Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 2592653002: [wrapper-tracing] Trace CustomElementReactionStack (Closed)

Created:
4 years ago by Michael Lippautz
Modified:
4 years ago
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, dominicc+watchlist_chromium.org, eae+blinkwatch, rwlbuis, sof, webcomponents-bugzilla_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[wrapper-tracing] Trace CustomElementReactionStack BUG=chromium:468240 Committed: https://crrev.com/abb137849163906b33e6eb8a0406a6b2728f59ac Cr-Commit-Position: refs/heads/master@{#439832}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -6 lines) Patch
M third_party/WebKit/Source/core/dom/custom/CustomElementReactionStack.h View 3 chunks +6 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/custom/CustomElementReactionStack.cpp View 2 chunks +7 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/custom/CustomElementRegistry.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/custom/CustomElementRegistry.cpp View 2 chunks +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/LocalDOMWindow.h View 3 chunks +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp View 2 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
Michael Lippautz
ptal and let me know if I understood you correctly ;)
4 years ago (2016-12-20 10:58:53 UTC) #2
haraken
LGTM
4 years ago (2016-12-20 13:31:50 UTC) #4
Michael Lippautz
On 2016/12/20 13:31:50, haraken wrote: > LGTM fyi: landing this now to give wrapper tracing ...
4 years ago (2016-12-20 17:12:04 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2592653002/1
4 years ago (2016-12-20 17:12:38 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-20 17:17:28 UTC) #14
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/abb137849163906b33e6eb8a0406a6b2728f59ac Cr-Commit-Position: refs/heads/master@{#439832}
4 years ago (2016-12-20 17:19:13 UTC) #16
dominicc (has gone to gerrit)
4 years ago (2016-12-22 03:59:11 UTC) #17
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698