Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 2592633002: Implement header size calculation for array iterators. (Closed)

Created:
4 years ago by titzer
Modified:
4 years ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Implement header size calculation for array iterators. R=bmeurer@chromium.org BUG=chromium:674232 Review-Url: https://codereview.chromium.org/2592633002 Cr-Commit-Position: refs/heads/master@{#41849} Committed: https://chromium.googlesource.com/v8/v8/+/cbd3b3d0fe2439f8835c81658a6d685a0ce95480

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -0 lines) Patch
M src/objects-inl.h View 1 chunk +4 lines, -0 lines 0 comments Download
A test/mjsunit/regress/regress-674232.js View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
titzer
4 years ago (2016-12-20 10:04:19 UTC) #1
Benedikt Meurer
LGTM, thanks.
4 years ago (2016-12-20 10:08:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2592633002/1
4 years ago (2016-12-20 10:36:40 UTC) #8
commit-bot: I haz the power
4 years ago (2016-12-20 10:38:22 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/cbd3b3d0fe2439f8835c81658a6d685a0ce...

Powered by Google App Engine
This is Rietveld 408576698