Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(478)

Side by Side Diff: Source/web/WebViewImpl.h

Issue 259263003: Fix to remove customised String over IPC for SmartClip (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: changed according to review comments by eseidel Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 228 matching lines...) Expand 10 before | Expand all | Expand 10 after
239 virtual void setCompositorDeviceScaleFactorOverride(float) OVERRIDE; 239 virtual void setCompositorDeviceScaleFactorOverride(float) OVERRIDE;
240 virtual void setRootLayerTransform(const WebSize& offset, float scale) OVERR IDE; 240 virtual void setRootLayerTransform(const WebSize& offset, float scale) OVERR IDE;
241 virtual WebDevToolsAgent* devToolsAgent() OVERRIDE; 241 virtual WebDevToolsAgent* devToolsAgent() OVERRIDE;
242 virtual WebAXObject accessibilityObject() OVERRIDE; 242 virtual WebAXObject accessibilityObject() OVERRIDE;
243 virtual void setSelectionColors(unsigned activeBackgroundColor, 243 virtual void setSelectionColors(unsigned activeBackgroundColor,
244 unsigned activeForegroundColor, 244 unsigned activeForegroundColor,
245 unsigned inactiveBackgroundColor, 245 unsigned inactiveBackgroundColor,
246 unsigned inactiveForegroundColor) OVERRIDE; 246 unsigned inactiveForegroundColor) OVERRIDE;
247 virtual void performCustomContextMenuAction(unsigned action) OVERRIDE; 247 virtual void performCustomContextMenuAction(unsigned action) OVERRIDE;
248 virtual void showContextMenu() OVERRIDE; 248 virtual void showContextMenu() OVERRIDE;
249 // TODO(AviD):This should be removed when the chromium side patch lands
Inactive 2014/06/09 14:00:51 Please use FIXME and without attribution: http://d
AviD 2014/06/13 11:52:48 Done.
250 // http://codereview.chromium.org/260623004
249 virtual WebString getSmartClipData(WebRect) OVERRIDE; 251 virtual WebString getSmartClipData(WebRect) OVERRIDE;
252 virtual void getSmartClipData(WebRect, WebString*, WebRect*) OVERRIDE;
250 virtual void hidePopups() OVERRIDE; 253 virtual void hidePopups() OVERRIDE;
251 virtual void addPageOverlay(WebPageOverlay*, int /* zOrder */) OVERRIDE; 254 virtual void addPageOverlay(WebPageOverlay*, int /* zOrder */) OVERRIDE;
252 virtual void removePageOverlay(WebPageOverlay*) OVERRIDE; 255 virtual void removePageOverlay(WebPageOverlay*) OVERRIDE;
253 virtual void transferActiveWheelFlingAnimation(const WebActiveWheelFlingPara meters&) OVERRIDE; 256 virtual void transferActiveWheelFlingAnimation(const WebActiveWheelFlingPara meters&) OVERRIDE;
254 virtual bool endActiveFlingAnimation() OVERRIDE; 257 virtual bool endActiveFlingAnimation() OVERRIDE;
255 virtual void setShowPaintRects(bool) OVERRIDE; 258 virtual void setShowPaintRects(bool) OVERRIDE;
256 void setShowDebugBorders(bool); 259 void setShowDebugBorders(bool);
257 virtual void setShowFPSCounter(bool) OVERRIDE; 260 virtual void setShowFPSCounter(bool) OVERRIDE;
258 virtual void setContinuousPaintingEnabled(bool) OVERRIDE; 261 virtual void setContinuousPaintingEnabled(bool) OVERRIDE;
259 virtual void setShowScrollBottleneckRects(bool) OVERRIDE; 262 virtual void setShowScrollBottleneckRects(bool) OVERRIDE;
(...skipping 456 matching lines...) Expand 10 before | Expand all | Expand 10 after
716 bool m_userGestureObserved; 719 bool m_userGestureObserved;
717 }; 720 };
718 721
719 // We have no ways to check if the specified WebView is an instance of 722 // We have no ways to check if the specified WebView is an instance of
720 // WebViewImpl because WebViewImpl is the only implementation of WebView. 723 // WebViewImpl because WebViewImpl is the only implementation of WebView.
721 DEFINE_TYPE_CASTS(WebViewImpl, WebView, webView, true, true); 724 DEFINE_TYPE_CASTS(WebViewImpl, WebView, webView, true, true);
722 725
723 } // namespace blink 726 } // namespace blink
724 727
725 #endif 728 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698