Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2225)

Unified Diff: Source/web/WebViewImpl.cpp

Issue 259263003: Fix to remove customised String over IPC for SmartClip (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: changed according to review comments by eseidel Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/web/WebViewImpl.cpp
diff --git a/Source/web/WebViewImpl.cpp b/Source/web/WebViewImpl.cpp
index 02f3e15eae35cc7fb3f648598f313663cb012b3a..3fc7582f0f8b6d6d078d896d75f411e0d1056e60 100644
--- a/Source/web/WebViewImpl.cpp
+++ b/Source/web/WebViewImpl.cpp
@@ -3410,12 +3410,14 @@ void WebViewImpl::showContextMenu()
m_contextMenuAllowed = false;
}
-WebString WebViewImpl::getSmartClipData(WebRect rect)
+void WebViewImpl::getSmartClipData(WebRect rect, WebString* clipText, WebRect* clipRect)
{
LocalFrame* frame = toLocalFrame(focusedWebCoreFrame());
if (!frame)
- return WebString();
- return WebCore::SmartClip(frame).dataForRect(rect).toString();
+ return;
+ SmartClipData clipData = WebCore::SmartClip(frame).dataForRect(rect);
+ *clipText = clipData.clipData();
+ *clipRect = clipData.rect();
}
void WebViewImpl::hidePopups()

Powered by Google App Engine
This is Rietveld 408576698