Remove networking API permissions depdendency on behavior feature

Remove networking API permissions depdendency on behavior feature

Docs server does not handle API dependency on behavior features, so
having networkingPrivate and networking.onc depend on a behavior
feature to provide white list breaks docserver preview.py.
To avoid the issue, replicate whitelists in _permission_features file
for each of the permissions.

BUG=676105, 672186
Committed: https://crrev.com/c1e3e116e8b8b3fd88eade4dae3521354ff8efd1
Cr-Commit-Position: refs/heads/master@{#440164}

[tbarzic, 2016-12-20 23:29:01]

tbarzic@chromium.org changed reviewers:
+ rdevlin.cronin@chromium.org

[tbarzic, 2016-12-20 23:29:02]

Note that I'm considering using the whitelisted_for_networking_onc_api behavior
feature soon (to check API availability for networking.onc API in few cases) -
if I end up not needing it, I'll remove that one as well.

[Devlin, 2016-12-21 02:47:25]

On 2016/12/20 23:29:02, tbarzic wrote:
> Note that I'm considering using the whitelisted_for_networking_onc_api
behavior
> feature soon (to check API availability for networking.onc API in few cases) -
> if I end up not needing it, I'll remove that one as well.

How soon is soon?  If it's not in the next couple of days, I'd say remove the
feature and then we can always re-add it. :)

https://codereview.chromium.org/2592613003/diff/1/extensions/common/api/_perm...
File extensions/common/api/_permission_features.json (right):

https://codereview.chromium.org/2592613003/diff/1/extensions/common/api/_perm...
extensions/common/api/_permission_features.json:349: "whitelist": [
It's a little sad to duplicate the whitelists, but I can understand it.  Can we
at least add something like:
// DO NOT ADD ANY MORE ENTRIES HERE.
// networkingPrivate is being migrated to networking.onc.
// TODO(tbarzic): Remove this.

[tbarzic, 2016-12-21 04:05:30]

Removed the behavior feature, too.

https://codereview.chromium.org/2592613003/diff/1/extensions/common/api/_perm...
File extensions/common/api/_permission_features.json (right):

https://codereview.chromium.org/2592613003/diff/1/extensions/common/api/_perm...
extensions/common/api/_permission_features.json:349: "whitelist": [
On 2016/12/21 02:47:25, Devlin wrote:
> It's a little sad to duplicate the whitelists, but I can understand it.  Can
we
> at least add something like:
> // DO NOT ADD ANY MORE ENTRIES HERE.
> // networkingPrivate is being migrated to networking.onc.
> // TODO(tbarzic): Remove this.

Yeah, it males me sad, too
Done

[Devlin, 2016-12-21 15:36:44]

lgtm

[tbarzic, 2016-12-21 17:39:24]

The CQ bit was checked by tbarzic@chromium.org

[commit-bot: I haz the power, 2016-12-21 17:39:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-21 18:41:07]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1482341964382730,
"parent_rev": "3bec35b89736689e52eed4f0210c6c503082bd48", "commit_rev":
"b3bfe893c9d824fc27b5d906ae951d055e27ac4f"}

[commit-bot: I haz the power, 2016-12-21 18:41:32]

Description was changed from

==========
Remove networking API permissions depdendency on behavior feature

Docs server does not handle API dependency on behavior features, so
having networkingPrivate and networking.onc depend on a behavior
feature to provide white list breaks docserver preview.py.
To avoid the issue, replicate whitelists in _permission_features file
for each of the permissions.

BUG=676105,672186
==========

to

==========
Remove networking API permissions depdendency on behavior feature

Docs server does not handle API dependency on behavior features, so
having networkingPrivate and networking.onc depend on a behavior
feature to provide white list breaks docserver preview.py.
To avoid the issue, replicate whitelists in _permission_features file
for each of the permissions.

BUG=676105,672186

Review-Url: https://codereview.chromium.org/2592613003
==========

[commit-bot: I haz the power, 2016-12-21 18:41:33]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-21 18:44:44]

Description was changed from

==========
Remove networking API permissions depdendency on behavior feature

Docs server does not handle API dependency on behavior features, so
having networkingPrivate and networking.onc depend on a behavior
feature to provide white list breaks docserver preview.py.
To avoid the issue, replicate whitelists in _permission_features file
for each of the permissions.

BUG=676105,672186

Review-Url: https://codereview.chromium.org/2592613003
==========

to

==========
Remove networking API permissions depdendency on behavior feature

Docs server does not handle API dependency on behavior features, so
having networkingPrivate and networking.onc depend on a behavior
feature to provide white list breaks docserver preview.py.
To avoid the issue, replicate whitelists in _permission_features file
for each of the permissions.

BUG=676105,672186

Committed: https://crrev.com/c1e3e116e8b8b3fd88eade4dae3521354ff8efd1
Cr-Commit-Position: refs/heads/master@{#440164}
==========

[commit-bot: I haz the power, 2016-12-21 18:44:44]

Patchset 2 (id:??) landed as
https://crrev.com/c1e3e116e8b8b3fd88eade4dae3521354ff8efd1
Cr-Commit-Position: refs/heads/master@{#440164}