Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1036)

Issue 2592593003: Upstream ios/showcase source code. (Closed)

Created:
4 years ago by lpromero
Modified:
4 years ago
Reviewers:
sdefresne
CC:
chromium-reviews, edchin
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Upstream ios/showcase source code. This is a dev-only, standalone app for Chrome for iOS development. It showcases (and is restricted to) UI elements used and developed for Chrome for iOS. BUG=653086 R=sdefresne@chromium.org Committed: https://crrev.com/fadd7245d91a9abc9dc962647d1e489bd8c317b6 Cr-Commit-Position: refs/heads/master@{#439773}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+997 lines, -5 lines) Patch
M ios/BUILD.gn View 1 chunk +2 lines, -1 line 0 comments Download
A ios/showcase/BUILD.gn View 1 chunk +63 lines, -0 lines 0 comments Download
A ios/showcase/DEPS View 1 chunk +3 lines, -0 lines 0 comments Download
A ios/showcase/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
A ios/showcase/common/BUILD.gn View 1 chunk +11 lines, -0 lines 0 comments Download
A ios/showcase/common/coordinator.h View 1 chunk +24 lines, -0 lines 0 comments Download
A ios/showcase/core/BUILD.gn View 1 chunk +43 lines, -0 lines 0 comments Download
A ios/showcase/core/Info.plist View 1 chunk +41 lines, -0 lines 0 comments Download
A ios/showcase/core/LaunchScreen.storyboard View 1 chunk +47 lines, -0 lines 0 comments Download
A ios/showcase/core/app_delegate.h View 1 chunk +16 lines, -0 lines 0 comments Download
A ios/showcase/core/app_delegate.mm View 1 chunk +41 lines, -0 lines 0 comments Download
A ios/showcase/core/main.mm View 1 chunk +17 lines, -0 lines 0 comments Download
A ios/showcase/core/showcase_egtest.mm View 1 chunk +25 lines, -0 lines 0 comments Download
A ios/showcase/core/showcase_model.h View 1 chunk +17 lines, -0 lines 0 comments Download
A ios/showcase/core/showcase_model.mm View 1 chunk +42 lines, -0 lines 0 comments Download
A ios/showcase/core/showcase_view_controller.h View 1 chunk +39 lines, -0 lines 0 comments Download
A ios/showcase/core/showcase_view_controller.mm View 1 chunk +202 lines, -0 lines 0 comments Download
A ios/showcase/settings/BUILD.gn View 1 chunk +16 lines, -0 lines 0 comments Download
A ios/showcase/settings/settings_coordinator.h View 1 chunk +19 lines, -0 lines 0 comments Download
A ios/showcase/settings/settings_coordinator.mm View 1 chunk +22 lines, -0 lines 0 comments Download
A ios/showcase/tab_grid/BUILD.gn View 1 chunk +29 lines, -0 lines 0 comments Download
A ios/showcase/tab_grid/sc_tab_grid_coordinator.h View 1 chunk +17 lines, -0 lines 0 comments Download
A ios/showcase/tab_grid/sc_tab_grid_coordinator.mm View 1 chunk +81 lines, -0 lines 0 comments Download
A ios/showcase/tab_grid/sc_tab_grid_egtest.mm View 1 chunk +31 lines, -0 lines 0 comments Download
M ios/showcase/test/BUILD.gn View 1 chunk +13 lines, -4 lines 0 comments Download
A ios/showcase/test/showcase_test_case.h View 1 chunk +14 lines, -0 lines 0 comments Download
A ios/showcase/test/showcase_test_case.mm View 1 chunk +31 lines, -0 lines 0 comments Download
A ios/showcase/uikit_table_view_cell/BUILD.gn View 1 chunk +12 lines, -0 lines 0 comments Download
A ios/showcase/uikit_table_view_cell/uikit_table_view_cell_view_controller.h View 1 chunk +13 lines, -0 lines 0 comments Download
A ios/showcase/uikit_table_view_cell/uikit_table_view_cell_view_controller.mm View 1 chunk +65 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 14 (9 generated)
lpromero
4 years ago (2016-12-20 10:38:08 UTC) #1
sdefresne
lgtm
4 years ago (2016-12-20 12:08:32 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2592593003/1
4 years ago (2016-12-20 12:08:40 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-20 12:22:55 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-20 12:26:12 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fadd7245d91a9abc9dc962647d1e489bd8c317b6
Cr-Commit-Position: refs/heads/master@{#439773}

Powered by Google App Engine
This is Rietveld 408576698