Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Issue 2592583002: UI changes on opt-in IME menu. (Closed)

Created:
4 years ago by Azure Wei
Modified:
3 years, 11 months ago
Reviewers:
tdanderson, James Cook
CC:
chromium-reviews, sadrul, yusukes+watch_chromium.org, shuchen+watch_chromium.org, nona+watch_chromium.org, oshima+watch_chromium.org, kalyank
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

UI changes on opt-in IME menu. 1) Make title row is 1dp bigger and text shifted down 2dp. 2) Make bottom row (tiles of icons) 1dp bigger. BUG=663199 TEST=Verfied on local build. Review-Url: https://codereview.chromium.org/2592583002 Cr-Commit-Position: refs/heads/master@{#442851} Committed: https://chromium.googlesource.com/chromium/src/+/d1f2198a42c85ae73a03d8ad29f11d85f336e9ef

Patch Set 1 #

Patch Set 2 #

Patch Set 3 #

Patch Set 4 : sync #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -5 lines) Patch
M ash/common/system/chromeos/ime_menu/ime_menu_tray.cc View 1 2 3 3 chunks +17 lines, -4 lines 0 comments Download
M ash/common/system/tray/tray_constants.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
Azure Wei
4 years ago (2016-12-20 11:16:41 UTC) #3
James Cook
LGTM
4 years ago (2016-12-20 17:54:10 UTC) #4
tdanderson
On 2016/12/20 17:54:10, James Cook wrote: > LGTM Sorry didn't see this, have been OOO. ...
3 years, 11 months ago (2017-01-09 23:12:42 UTC) #5
Azure Wei
On 2017/01/09 23:12:42, tdanderson wrote: > On 2016/12/20 17:54:10, James Cook wrote: > > LGTM ...
3 years, 11 months ago (2017-01-10 13:08:41 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2592583002/60001
3 years, 11 months ago (2017-01-11 08:16:15 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-11 10:24:50 UTC) #12
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/d1f2198a42c85ae73a03d8ad29f1...

Powered by Google App Engine
This is Rietveld 408576698