Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Issue 2592563003: [wasm] Add test for reexport of the same import twice. (Closed)

Created:
4 years ago by titzer
Modified:
4 years ago
Reviewers:
Clemens Hammacher
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Add test for reexport of the same import twice. R=clemensh@chromium.org BUG= Review-Url: https://codereview.chromium.org/2592563003 Cr-Commit-Position: refs/heads/master@{#41850} Committed: https://chromium.googlesource.com/v8/v8/+/e797e0ea6d01ed84a23345ddf077157091d65648

Patch Set 1 #

Total comments: 2

Patch Set 2 : Added test for second case. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -0 lines) Patch
M test/mjsunit/wasm/export-table.js View 1 1 chunk +41 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
titzer
4 years ago (2016-12-20 09:45:21 UTC) #1
Clemens Hammacher
lgtm https://codereview.chromium.org/2592563003/diff/1/test/mjsunit/wasm/export-table.js File test/mjsunit/wasm/export-table.js (right): https://codereview.chromium.org/2592563003/diff/1/test/mjsunit/wasm/export-table.js#newcode149 test/mjsunit/wasm/export-table.js:149: let instance = builder.instantiate({a: js, b: js}); b ...
4 years ago (2016-12-20 09:51:39 UTC) #4
titzer
https://codereview.chromium.org/2592563003/diff/1/test/mjsunit/wasm/export-table.js File test/mjsunit/wasm/export-table.js (right): https://codereview.chromium.org/2592563003/diff/1/test/mjsunit/wasm/export-table.js#newcode149 test/mjsunit/wasm/export-table.js:149: let instance = builder.instantiate({a: js, b: js}); On 2016/12/20 ...
4 years ago (2016-12-20 10:13:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2592563003/20001
4 years ago (2016-12-20 10:14:31 UTC) #10
commit-bot: I haz the power
4 years ago (2016-12-20 10:43:59 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/e797e0ea6d01ed84a23345ddf077157091d...

Powered by Google App Engine
This is Rietveld 408576698